fix(operator): move to use leader election by lease

Fixes #711

Signed-off-by: Aslak Knutsen <aslak@4fs.no>

config/rbac/kustomization.yaml

@@ -1,8 +1,8 @@
 resources:
 - role.yaml
 - role_binding.yaml
-#- leader_election_role.yaml
-#- leader_election_role_binding.yaml
+- leader_election_role.yaml
+- leader_election_role_binding.yaml
 # Comment the following 4 lines if you want to disable
 # the auth proxy (https://github.com/brancz/kube-rbac-proxy)
 # which protects your /metrics endpoint.

config/rbac/leader_election_role_binding.yaml

@@ -8,5 +8,5 @@ roleRef:
   name: leader-election-role
 subjects:
 - kind: ServiceAccount
-  name: default
+  name: istio-workspace
   namespace: system

pkg/cmd/serve/cmd.go

@@ -1,13 +1,11 @@
 package serve
 
 import (
-	"context"
 	"fmt"
 	"os"
 	"strings"
 
 	"github.com/go-logr/logr"
-	"github.com/operator-framework/operator-lib/leader"
 
 	"github.com/maistra/istio-workspace/api"
 	"github.com/maistra/istio-workspace/controllers"
@@ -63,18 +61,13 @@ func startOperator(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	ctx := context.Background()
-
-	// Become the leader before proceeding
-	if e := leader.Become(ctx, "istio-workspace-lock"); e != nil {
-		logger().Error(e, "")
-		return e
-	}
-
 	managerOptions := manager.Options{
 		MetricsBindAddress:     fmt.Sprintf("%s:%d", metricsHost, metricsPort),
 		HealthProbeBindAddress: "0.0.0.0:8282",
+		LeaderElection:         true,
+		LeaderElectionID:       "istio-workspace-lock",
 	}
+
 	if len(namespaces) == 1 {
 		managerOptions.Namespace = namespaces[0]
 	} else {