Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stuck in Leader Election on upgrade #711

Closed
aslakknutsen opened this issue Feb 22, 2021 · 1 comment · Fixed by #715
Closed

Stuck in Leader Election on upgrade #711

aslakknutsen opened this issue Feb 22, 2021 · 1 comment · Fixed by #715
Labels
component/operator Component: Operator service kind/bug Kind: Not working as expected MVP MVP Required Issue
Milestone
v0.0.8

Comments

@aslakknutsen
Copy link
Member

Issue Overview

When installing the Operator from Operator Hub and a new version arrives it's impossible to perform the upgrade.

Expected Behaviour

The new version is deployed, the old version is deleted and everyone is happy.

Current Behaviour

The new version is running and is the elected leader. The new version deploys but never reach Readiness because it's waiting to become leader. Update eventually fail.

Steps To Reproduce
  1. Install v 0.0.6
  2. Update to 0.0.7
@aslakknutsen aslakknutsen added kind/bug Kind: Not working as expected component/operator Component: Operator service MVP MVP Required Issue labels Feb 22, 2021
@aslakknutsen aslakknutsen added this to the v0.0.8 milestone Feb 22, 2021
@bartoszmajsak
Copy link
Contributor

Caused by operator-framework/operator-lib#48

It seems that the solution is to change to the controller-runtime approach which is election-by-lease.

aslakknutsen added a commit that referenced this issue Feb 23, 2021
@aslakknutsen
fix(operator): move to use leader election by lease
51c6540 
Fixes #711

Signed-off-by: Aslak Knutsen <aslak@4fs.no>
@aslakknutsen aslakknutsen mentioned this issue Feb 23, 2021
Merged
aslakknutsen added a commit that referenced this issue Feb 23, 2021
@aslakknutsen
fix(operator): move to use leader election by lease
2582755 
Fixes #711

Signed-off-by: Aslak Knutsen <aslak@4fs.no>
aslakknutsen added a commit that referenced this issue Feb 23, 2021
@aslakknutsen
fix(operator): move to use leader election by lease (#715)
8277cb4 
Fixes #711

Signed-off-by: Aslak Knutsen <aslak@4fs.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/operator Component: Operator service kind/bug Kind: Not working as expected MVP MVP Required Issue
Projects
None yet
Milestone
v0.0.8
Development

Successfully merging a pull request may close this issue.

fix(operator): move to use leader election by lease maistra/istio-workspace
2 participants
@aslakknutsen @bartoszmajsak