src: no need to log http request #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loadbalancer should do this job instead
makemek
force-pushed
the
no-http-request-logging
branch
from
cc0f3cd to
fc654f8
Compare
makemek
added a commit
that referenced
this pull request
Apr 29, 2017
Loadbalancer should do this job instead PR-URL: #45
|
Landed in 42d7d69 |
makemek
added a commit
that referenced
this pull request
May 1, 2017
Loadbalancer should do this job instead PR-URL: #45
Closed
makemek
added a commit
that referenced
this pull request
May 1, 2017
Loadbalancer should do this job instead PR-URL: #45
makemek
added a commit
that referenced
this pull request
May 1, 2017
Notable Changes: * All environment varaibles are loaded from process.yml which requires pm2 to start #30 * `cklg` cookie are not required to access DMM game page and will not be not be injected to a request #37 * No logging router requests. #45 * Use pino logger over winston for better performance #44 PR-URL: #52
makemek
added a commit
that referenced
this pull request
May 1, 2017
Notable Changes: * All environment varaibles are loaded from process.yml which requires pm2 to start #30 * `cklg` cookie are not required to access DMM game page and will not be not be injected to a request #37 * No logging router requests. #45 * Use pino logger over winston for better performance #44 PR-URL: #52
makemek
added a commit
that referenced
this pull request
May 1, 2017
Notable Changes: * All environment varaibles are loaded from process.yml which requires pm2 to start #30 * `cklg` cookie are not required to access DMM game page and will not be not be injected to a request #37 * No logging router requests. #45 * Use pino logger over winston for better performance #44 PR-URL: #52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to log http request
I think load balancer like Nginx should do the logging instead.
Less logging overhead.