v0.3.2 proposal #52
Closed
v0.3.2 proposal #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine all environment variables in process.yml. Package dot-env which loads .env.json is no longer required. PR-URL: #30
* 'npm start' loads env from process.yml using pm2 * easy-to-see header with remarks in npm start PR-URL: #33
Injecting DMM cookie 'ckcy' is sufficient enough to access DMM game. Injecting 'cklg' to DMM cookie is not neccessary. PR-URL: #37
Implement Injector using a javascript `class` over relying on dependency `inherit` PR-URL: #37
Loadbalancer should do this job instead PR-URL: #45
LOGGER_ENABLE and LOGGER_PRETTY expect boolean value but receive a string PR-URL: #46
LOGGER_LEVEL has 'silent' which disable a log. Having LOGGER_ENABLE is redundant. PR-URL: #46
By default all pm2 logs that are not location specific will be in ~/.pm2 PR-URL: #47
makemek
added a commit
that referenced
this pull request
May 1, 2017
Notable Changes: * All environment varaibles are loaded from process.yml which requires pm2 to start #30 * `cklg` cookie are not required to access DMM game page and will not be not be injected to a request #37 * No logging router requests. #45 * Use pino logger over winston for better performance #44 PR-URL: #52
makemek
added a commit
that referenced
this pull request
May 1, 2017
Notable Changes: * All environment varaibles are loaded from process.yml which requires pm2 to start #30 * `cklg` cookie are not required to access DMM game page and will not be not be injected to a request #37 * No logging router requests. #45 * Use pino logger over winston for better performance #44 PR-URL: #52
|
merged!, release will be out soon |
makemek
added a commit
that referenced
this pull request
May 1, 2017
Notable Changes: * All environment varaibles are loaded from process.yml which requires pm2 to start #30 * `cklg` cookie are not required to access DMM game page and will not be not be injected to a request #37 * No logging router requests. #45 * Use pino logger over winston for better performance #44 PR-URL: #52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2017.05.01, Version 0.3.2
Notable Changes
cklgcookie are not required to access DMM game page and will not be not be injected to a request src: remove injecting 'cklg' cookie #37Commits
c9dc676] doc: update outdated configuration section00881de] doc: start the application in production modeaa44463] fix(package): update pino to version 4.5.05562000] chore(package): update async to version 2.4.01b35907] config: use default pm2 log dircb52dd4] config: remove LOGGER_ENABLE optionc56d994] config: fix can't config LOGGER_ENABLE and LOGGER_PRETTY42d7d69] src: no need to log http requestf046d7b] src: replace winston logger with pino loggerda91530] chore(package): update nyc to version 10.3.0ca72694] src: refactor code to be es6 complientaa37ff8] build: reduce docker image sizebad5e15] chore(package): update coveralls to version 2.13.1b4bba33] build: start process.yml using production environment1d60216] build: fix pm2-docker not found config file89fbdda] src: js class implementation in cookie injector087d1d7] src: remove injecting 'cklg' cookie69222dd] build: 'gulp build' and 'gulp import' as default taskbc1586e] src: replace sprintf-js with es6 string templatee9a7153] dep: dev package should be in devDependencies875fe86] npm,doc: 'npm start' will launch app using pm2f7cce20] chore(package): update mocha to version 3.3.0aa94733] doc: remarks when running in development modeeac0f9a] pm2,bin,test: load all app's envs from process.yml34549ba] pm2,doc: prefer starting the app with pm2 yml config