Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile with mlua anymore #89

Closed
LaserWitch opened this issue Dec 15, 2023 · 4 comments
Closed

Can't compile with mlua anymore #89

LaserWitch opened this issue Dec 15, 2023 · 4 comments

Comments

@LaserWitch
Copy link
Contributor

LaserWitch commented Dec 15, 2023

I started towards trying to do my own update to bevy 0.12(haven't not noticed the issue here recently that mentioned it being possibly coming soon), and I've found that I can't build from the repo at all now when I use the lua-api and lua54 features. I get a bunch of errors from tealr macros. tealr_derive::TypeName, ToTypename, IntoLua... I'm thinking there's been some poorly-versioned breaking changes up stream but haven't yet found a correct combination of version specifications to get back to buildable.

@LaserWitch LaserWitch changed the title Can't compile anymore Can't compile with mlua anymore Dec 15, 2023
@makspll
Copy link
Owner

makspll commented Dec 15, 2023

Hi, I think tealr got an update, I remember there being some issues with cargo selecting unexpected versions for it, have a look at: lenscas/tealr_doc_gen#18,
Solution is to either:

  • figure out how to make cargo respect the alpha version
  • update to the newest tealr version

@makspll
Copy link
Owner

makspll commented Dec 15, 2023

W.r.t bevy 0.12 I am currently heavily invested on this branch: https://github.com/makspll/bevy_mod_scripting/tree/feature/derive_macros

basically a complete re-write of the codegen + possibly allowing consumers to generate an API similarly to how we do it for Bevy (except hopefully completely automatically), and was hoping to finish that before releasing, but given it's taking me way longer than expected, I might just release a pure bevy patch (for both 0.11 and 0.12), and PR's are very much welcome!

@LaserWitch
Copy link
Contributor Author

Right now my own project is awkwardly pinned to a bevy 0.12-dev version to clean up some issues, so I was trying to do a 0.12 patch to be able to be solidly on released bevy version. I'll see if I can do an update to just current tealr versions to get that cleaned up and then move on to the 0.12.

LaserWitch added a commit to LaserWitch/bevy_mod_scripting that referenced this issue Dec 16, 2023
@lenscas
Copy link

lenscas commented Dec 17, 2023

Sorry about this. I didn't know (nor expected) that me releasing a non alpha version would break this. In fact, as far as I understand how cargo should resolve versions it should go for the exact version if you add stuff like --alpha after the version number. I guess I need to re read how this part work to prevent it from happening in the future.

Again, sorry that this happened. It was not at all my intention to break anything, and especially not without notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants