Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tealr dependancy #90

Closed
wants to merge 1 commit into from
Closed

Conversation

LaserWitch
Copy link
Contributor

This is an attempt to get around compilation issues with lua versions.
Unfortunately it's not working yet. It seems there's some trait changes that impact codegen that I'm not sure how to fix yet. I figured a draft PR with my partial work might still be of value to someone, at least.

@LaserWitch
Copy link
Contributor Author

LaserWitch commented Dec 16, 2023

I have belatedly realized, after properly digesting the cause identified to me in #89, that the root issue can be handled much more expediently with a [patch] section in the main cargo file to point at the github revision of 0.9.0-alpha4.
It'd be good for the crate to point to a non-alpha version of tealr eventually, but perhaps that can wait for the new codegen before being tackled.
I'll submit a pr for that this weekend if not tonight

@makspll
Copy link
Owner

makspll commented Dec 16, 2023

Oh yes I think tealr also updated the mlua version which had some big changes to the way FromLua worked

@LaserWitch
Copy link
Contributor Author

Superseded for now by #90

@LaserWitch LaserWitch closed this Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants