Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds TrafficLightBook and TrafficLight classes. #91

Merged
merged 1 commit into from
May 21, 2024
Merged

Adds TrafficLightBook and TrafficLight classes. #91

merged 1 commit into from
May 21, 2024

Conversation

francocipollone
Copy link
Contributor

@francocipollone francocipollone commented May 14, 2024 •
edited
Loading

🎉 New feature

Related to:

Summary

  • Creates rules module
  • Adds TrafficLightBook bindings and Rust API
  • Adds TrafficLight class and id() binding.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

This was referenced May 14, 2024
Open
Closed
Open
Closed
Closed
@francocipollone
Adds TrafficLightBook and TrafficLight classes.
fae0606 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone force-pushed the francocipollone/traffic_light branch from f052e64 to fae0606 Compare May 15, 2024 19:18
@francocipollone francocipollone mentioned this pull request May 15, 2024
Merged
6 tasks
@agalbachicar agalbachicar self-requested a review May 21, 2024 07:42
agalbachicar
agalbachicar approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maliput/src/api/mod.rs
@@ -1353,7 +1366,7 @@ impl<'a> IntersectionBook<'a> {
/// * `id` - The id of the Intersection to get.
///
/// ## Returns
/// * An Option<Intersection>
/// * An `Option<Intersection>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the next lines? Shouldn't we use ` (backticks) as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use backticks. If we don't have backticks a warning is raised by cargo doc command:

image

I should have added this change to a separate PR tho.

@francocipollone francocipollone merged commit 09fee77 into main May 21, 2024
3 checks passed
@francocipollone francocipollone deleted the francocipollone/traffic_light branch May 21, 2024 12:50
@francocipollone francocipollone mentioned this pull request Jun 5, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar