Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrafficLights: Bindings for getting the pose. #98

Merged
merged 1 commit into from
May 21, 2024
Merged

TrafficLights: Bindings for getting the pose. #98

merged 1 commit into from
May 21, 2024

Conversation

francocipollone
Copy link
Contributor

@francocipollone francocipollone commented May 15, 2024 •
edited
Loading

🎉 New feature

Goes on top of #91
Related to:

Summary

Bindings and Rust API for:

  • TrafficLight: position_road_network
  • TrafficLight: orientation_road_network

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This was referenced May 15, 2024
Closed
Closed
Merged
agalbachicar
agalbachicar previously approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from francocipollone/traffic_light to main May 21, 2024 12:50
@francocipollone francocipollone dismissed agalbachicar’s stale review May 21, 2024 12:50

The base branch was changed.

@francocipollone
TrafficLights: Bindings for getting the pose.
55d43ba 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone force-pushed the francocipollone/2_traffic_light branch from 48c3bd8 to 55d43ba Compare May 21, 2024 12:53
@francocipollone francocipollone merged commit a10e355 into main May 21, 2024
3 checks passed
@francocipollone francocipollone deleted the francocipollone/2_traffic_light branch May 21, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar