Skip to content
This repository has been archived by the owner on Jun 21, 2024. It is now read-only.

Update userscript.js actionsButtons and activityPanel #232

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

Mini-Gaunt
Copy link
Contributor

Update for discord web changes, fixes issue with start stream button.

@MrakDun-desu
Copy link

Tried to build this with Debian 12, audio sharing works now, but after the change the video doesn't work instead, possibly because of outdated Debian libraries.

The main start stream button in the middle of the screen still doesn't work though, only the small one on the bottom left.

@Mini-Gaunt
Copy link
Contributor Author

Tried to build this with Debian 12, audio sharing works now, but after the change the video doesn't work instead, possibly because of outdated Debian libraries.

The main start stream button in the middle of the screen still doesn't work though, only the small one on the bottom left.

I think the start stream button in the center is supposed to be grayed out, at least according to the most recent commit. I will take a quick look to see if that is also a quick fix

update wrapper and controlButton names
update mute/deafen container
f00d4tehg0dz added a commit to f00d4tehg0dz/kasm-discord-screenshare that referenced this pull request Mar 31, 2024
* Using PR 232 from discord-screenaudio to resolve the screenshare button not working. maltejur/discord-screenaudio#232
* TODO ( add screenshare button icon )
@maltejur
Copy link
Owner

maltejur commented Apr 1, 2024

Thanks for the fix, I'll do another release with it.

@maltejur maltejur merged commit 2214452 into maltejur:master Apr 1, 2024
2 checks passed
@sumeet
Copy link

sumeet commented Apr 2, 2024

i tried this fix, and it looks like the screensharing and audio work, but changing the video quality settings don't actually take effect. seems to be set to 720 / 30fps no matter what i select.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants