Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyright pre-commit hook #607

Merged
merged 24 commits into from
Feb 18, 2023
Merged

Conversation

janjagusch
Copy link
Collaborator

@janjagusch janjagusch commented Feb 18, 2023

Depends on #608

To spot bugs like in #66, I'm adding pyright as a pre-commit hook. For now I've disabled most pyright checks to make CI pass. I will gradually enable more checks and add code fixes, but that will happen in separate PRs.

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Base: 82.48% // Head: 81.61% // Decreases project coverage by -0.88% ⚠️

Coverage data is based on head (6bdc4f5) compared to base (21ccbdd).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   82.48%   81.61%   -0.88%     
==========================================
  Files          78       78              
  Lines        6070     6070              
==========================================
- Hits         5007     4954      -53     
- Misses       1063     1116      +53     
Impacted Files Coverage Δ
quetz/pkgstores.py 42.48% <0.00%> (-11.55%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@janjagusch janjagusch changed the title Add pyright to pre-commit hooks Add pyright pre-commit hook Feb 18, 2023
@janjagusch janjagusch marked this pull request as ready for review February 18, 2023 18:52
@janjagusch janjagusch mentioned this pull request Feb 18, 2023
@janjagusch janjagusch merged commit 7bea725 into mamba-org:main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants