Fix unbound variables #609
Conversation
This reverts commit c1bde71.
…rtUnboundVariable
janjagusch
changed the title
| @@ -142,7 +142,7 @@ def test_repodata_zchunk( | |||
| with open('repodata.json') as f: | |||
| repodata_unzck = f.read() | |||
|
|
|||
| assert repodata == repodata_unzck # NOQA | |||
| assert repodata == repodata_unzck # NOQA # type: ignore | |||
There was a problem hiding this comment.
This seems utterly broken. The repodata variable isn't defined anywhere. Do we run the plugin tests in CI?
There was a problem hiding this comment.
We do, i can check this tomorrow 👍🏼
There was a problem hiding this comment.
Probably the if branch is never run, and the else branch doesn't contain any asserts 🤷🏼♂️
| version_order = ( | ||
| v.version_order if is_newer else v.version_order + 1 # type: ignore | ||
| ) |
There was a problem hiding this comment.
This needs to be improved.
janjagusch
changed the title
…rtUnboundVariable
janjagusch
changed the title
Codecov ReportBase: 82.46% // Head: 81.50% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
- Coverage 82.46% 81.50% -0.97%
==========================================
Files 78 78
Lines 6085 6104 +19
==========================================
- Hits 5018 4975 -43
- Misses 1067 1129 +62
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Depends on #607
Closes #606
This is a first attempt to fix all possibly unbound variables in the code. I've decided to use the most straightforward fix I could think of. But I feel like some of the code has structural problems and that a refactoring might be in order.