Cherry pick upstream bgfx commits needed to get wayland working #11539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* allow headless context creation using EGL * Fixed dynamic lib import --------- Co-authored-by: Dahmen issam <issam.dahmen@fittingbox.com>
Co-authored-by: Dahmen issam <issam.dahmen@fittingbox.com>
* Fixed EGL library name on Linux * Cleanup. --------- Co-authored-by: Dahmen issam <issam.dahmen@fittingbox.com> Co-authored-by: Бранимир Караџић <branimirkaradzic@gmail.com>
* Initial proof-of-concept of vulkan renderer working on wayland * Get wayland surface from the window handle
* Allow simultaneous X11 and Wayland support * Add NativeWindowHandleType * Set default value for g_platformData.type * Use g_platformData.type to check for a native Wayland window * Stub getNativeWindowHandleType on platform where Wayland is not an option * Implement getNativeWindowHandleType for GLFW * Add getNativeWindowHandleType to the remaining C++ examples * Add getNativeWindowHandleType to the C example
|
No immediate crashes on Fedora 38 running 535.xx nvidia driver or on windows 11. |
|
No crashes with normal shaders on Fedora 37 running 470.xx driver on a system with GeForce 680M either. |
|
I’ve read the diff, and I think this is relatively safe. I’m still going to hold off until after freeze to merge it as we’re no longer early in a release cycle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As full upstream sync has resulted in numerous issues, particularly with macOS (see #11493), cherry-pick the commits needed for wayland support (#11451) instead.
I have tested this on AMD opensource driver for now. I will test a few more configs and remove the draft status when done.