-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install script improvements. #99
base: master
Are you sure you want to change the base?
Install script improvements. #99
Conversation
Added ability to persist custom local configuration through externally referenced batch file. Example file is provided. For local custom file, added to gitignore. With this to be able to test faster, added variable for selecting tasks manually, and also when mysql connection information is explicitly given, skipping that page as well. Changed all mysql calls to use connection string variable layer to aid in customization, also involded in the above mentioned. From these additions, primitive parameters are also added for forcing prompt or none in case a condition is otherwise met either way. Added check to existing newpass so that script could continue when that variable was not provided so the original default one would trigger it erroneously even if not creating a mangos user. Fixed all mysql calls for version 8 or the way I was calling the program that was having trouble setting default database name to use flag prefix which works better. Recently also heard of a want to disable all tasks manually first, so added choice for that. Simplified color check.
@Pysis868 - I noticed a minor problem with the script when you change the options to no: Selecting N for Next closes the script - this is wrong !! Could you also up the version number to 2.1... Thanks |
When no connection string provided. I hate batch........
Needed some more refactoring.. Started splitting the mysql variables helps deal with then in cursed batch with quotes and checking their valus with if statements... The problem was checking what is not the Dir variable when it does not exist AND trying to replace any quotes it did have which outputs an '=' when it does not which breaks if conditions..... So this way the variable is always set with a default and the user can still override it.. With the variables split, the scripts reads better and is easier to maintain now. Added debug flag to preserve functionality lost when splitting the vars to no longer use the single one as an expression. Easy with things refactored now using the mysql command variable everywhere. I hate batch....
…y Atom editor to not strip the spacing O_o.... Fixed bug near population line too with pad. Don't think I broke those :P. Just from beginning with necro's commit. Not aware of the source before that. Added defaults option too. Hard to find a letter. What's the convention for picking these? Can we change them to be in order or something easier????
@Pysis868 would you also be able to add in the changes made to the bat file in this commit: |
Commit: 46300f1d5b14a9ff7d27de0b3efdeb3889e59f39 [46300f1] Parents: 22a9020cab Author: Antz <billy1arm@users.noreply.github.com> Date: Thursday, June 25, 2020 11:32:38 AM Committer: Antz [Locale] Fix up installation script
# Conflicts: # InstallDatabases.bat
…r's dynamic ones. More fixed spacing.
…ly installed on Windows hosts for remote setup.
# Conflicts: # Translations
| __ __ _ _ ___ ___ ___ | What is your MySQL host name? DEFAULT: [localhost] :~~~.~~~.~~~.~~~ | | Creating Database m1n | | '-D' is not recognized as an internal or external command, | | Creating Database c1n | | Loading Database c1n | | Creating Database r1n | | Loading Database r1n | | Adding Realmlist entry to r1n '-D' is not recognized as an internal or external command, | | | | | | | __ __ _ _ ___ ___ ___ | Script has completed !
Press any key to continue . . .` |
For anyone who has installed mysql 8.x. |
Added ability to persist custom local configuration through externally referenced batch file.
Example file is provided.
For local custom file, added to gitignore.
With this to be able to test faster, added variable for selecting tasks manually, and also when mysql connection information is explicitly given, skipping that page as well.
Changed all mysql calls to use connection string variable layer to aid in customization, also involded in the above mentioned.
From these additions, primitive parameters are also added for forcing prompt or none in case a condition is otherwise met either way.
Added check to existing newpass so that script could continue when that variable was not provided so the original default one would trigger it erroneously even if not creating a mangos user.
Fixed all mysql calls for version 8 or the way I was calling the program that was having trouble setting default database name to use flag prefix which works better.
Recently also heard of a want to disable all tasks manually first, so added choice for that.
Simplified color check.
This change is