Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding quick & custom ID route #132

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Pysis868
Copy link
Contributor

@Pysis868 Pysis868 commented Feb 11, 2023

Deja Vu: mangosone/database#99

Also really shouldn't be packaging third-party binaries.
Reasonable and easy for everyone to install a database client themselves, even if their system does not run the server.
So let's remove those tool exes too.

Also bet you want to keep core packages separate, but we could still change to having 1 repository to help unify the database tooling, and serve the rest as data packages. That would really make it properly clean.

Should probably split mangos user creation and grant steps too.


This change is Reviewable

With additional toggle entry,
automatic environment variable loading and retention,
DB client choice and usage flexibility with debug output control,
and the same for overall script flow control too,
including some other output control like OS detection,
extracted core specific info for easier and more efficient future code file updates between cores,
almost similarly for the script and release version variables,
and editor trailing space protection relevant to printing menu and prompt text.
File had only LFs causing trouble jumping to specific labels such as `ToggleRealmDB` and `RealmDB2`.
Pysis868 added a commit to Pysis868/DatabaseZero that referenced this pull request Feb 22, 2023
Just so it barely functions better mostly with the files it already has, plus the quick script that I added.
World FullDB had 2 errors, create scripts could probably be included in bat file allowing customizable schema names, even this entire project could be deduplicated with the main one, which could be done for all C++ cores as well, including the data if it is the same too.
Quick script adapted from mangoszero/database#132.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant