-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all user-initiated events should include originalEvent #1975
Comments
I agree. Some work already started on this in #1969 I would need to add these to When you say "all"... I'm assuming you don't mean things like when user uses the zoom in/out or rotate controls. We wouldn't want to propagate those click events, nor unproject and pass along the lng/lat underneath where the buttons happen to be. |
An alternative idea is to create a way for API-initiated events to not fire events, or indicate their sourcing in the same way. |
@tmcw can you review e585f88 and see if that would help. Going forward I'd like for all handlers to pass the original event source on to the camera methods. Alternatively if you call camera methods directly, you could pass your own sourcing data in that parameter, then watch for it in the receiving code. |
In order to determine the source of a map event, we need to specify originalEvent on any event initiated by a user.
The text was updated successfully, but these errors were encountered: