Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event handling improvements #1969

Closed
wants to merge 5 commits into from
Closed

Event handling improvements #1969

wants to merge 5 commits into from

Conversation

bhousel
Copy link
Contributor

@bhousel bhousel commented Jan 22, 2016

Related improvements involving the event handlers.

@mourner
Copy link
Member

mourner commented Jan 22, 2016

Is there a reason to pack independent changes into one PR? It's easier to review small focused PRs and it's nice to be able to merge independently (e.g. in case one change is ready to merge while the other drags for a week).

@bhousel
Copy link
Contributor Author

bhousel commented Jan 22, 2016

Is there a reason to pack independent changes into one PR? It's easier to review small focused PRs and it's nice to be able to merge independently (e.g. in case one change is ready to merge while the other drags for a week).

When issues are related I like to keep them together on a single feature branch to preserve the commit order and avoid merge conflicts. But I can break it up into different PRs, that's fine too.

@bhousel
Copy link
Contributor Author

bhousel commented Jan 27, 2016

merged!

@bhousel bhousel closed this Jan 27, 2016
@jfirebaugh jfirebaugh changed the title Event handling improvements Event handling improvements Jan 27, 2016
@bhousel bhousel deleted the more_events branch January 27, 2016 02:30
@bhousel bhousel mentioned this pull request Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants