Pin chrome to version 91 #10887
Merged
Pin chrome to version 91 #10887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rreusser
approved these changes
Jul 20, 2021
|
Setup a reminder issue pinned in the repo |
HeyStenson
pushed a commit
that referenced
this pull request
Jul 20, 2021
* `jsdoc/require-param-type` linting * Switch `Callback` to `Function` as per other callbacks defined in map.js * Pin chrome to version 91 (#10887) * Pin to chrome version 91 * Pin chrome version for test-browser Co-authored-by: Dom Brassey <dom.brassey@mapbox.com>
SnailBones
pushed a commit
that referenced
this pull request
Jul 21, 2021
* Pin to chrome version 91 * Pin chrome version for test-browser
SnailBones
pushed a commit
that referenced
this pull request
Jul 26, 2021
* Pin to chrome version 91 * Pin chrome version for test-browser
ryanhamley
pushed a commit
that referenced
this pull request
Jul 27, 2021
* Pin to chrome version 91 * Pin chrome version for test-browser
ryanhamley
pushed a commit
that referenced
this pull request
Jul 27, 2021
HeyStenson
added a commit
that referenced
this pull request
Jul 28, 2021
* mapeventdata --> mapdataevent * added require-property * change warns to fails * update tests * ALL THE TESTS * restore events.js * updates and upgrades * increase rigor of tests * fix eslint errors for jsdoc examples (#10847) * Add a few more examples (#10850) * Add a few examples * Update src/geo/mercator_coordinate.js Co-authored-by: Ansis Brammanis <ansis@mapbox.com> Co-authored-by: Ansis Brammanis <ansis@mapbox.com> * Add some docs example (#10859) * `require-example` linting (#10855) * Add geojson source examples * Add src/source/* inline examples * Linter * Lint * Add camera examples * Fixup * Add camera examples * Review comments * Minor nit * Apply jsdoc eslint rules only to public API files (#10854) * `require-example` linting (#10862) * Last public facing examples * Exclude private files from geo/ and promote require-example from warning to error * `jsdoc/newline-after-description` linting (#10863) * Update doc comments to conform to eslint-complete-sentences rule (#10851) * Update doc comments to conform to eslint-complete-sentences rule * Fix typo * more detailed docs for return `this` Extracted from Arindam's #10848 * Fix docs language * Make complete-sentences an error * Update eslintrc * Cleanup * Respond to feedback Co-authored-by: Ansis Brammanis <ansis@mapbox.com> * Non-test content updates (#10868) * GL-JS --> Mapbox GL JS * GL JS --> Mapbox GL JS * remove e.g. * remove i.e. * Update src/ui/camera.js * Resolves `eslint-plugin-jsdoc` test failures (#10858) * Adds 'resource type' prefix for related items in GL JS API docs (#10837) Co-authored-by: Asheem Mamoowala <asheem.mamoowala@mapbox.com> Co-authored-by: Heather Stenson <heather.stenson@mapbox.com> Co-authored-by: Karim Naaji <karim.naaji@gmail.com> Co-authored-by: Arindam Bose <arindam.bose@mapbox.com> Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com> * `jsdoc/check-types` linting (#10864) * `jsdoc/check-types` linting: `Object` -> `object` * Back to `Object` :| * remove tests: check-indentation, check-alignment, check-tag-names, no-bad-blocks, valid-types, require-throws * fix check-line-alignment and turn almost all tests to error * change require-param-type to warn and fix that pesky sentence * `jsdoc/require-param-type` linting (#10867) * `jsdoc/require-param-type` linting * Switch `Callback` to `Function` as per other callbacks defined in map.js * Pin chrome to version 91 (#10887) * Pin to chrome version 91 * Pin chrome version for test-browser Co-authored-by: Dom Brassey <dom.brassey@mapbox.com> * Add default values to some map API methods (#10823) * Add default values to map methods * Add default style value * Add customAttribution default * Add default value for container * do not represent container as optional with value null * do not represent style as optional with value null * capitalize first letter Co-authored-by: Dom Brassey <dom.brassey@mapbox.com> Co-authored-by: HeyStenson <heather.stenson@mapbox.com> * "jsdoc/require-property-description" rule and fixes to events.js (#10870) * Merging * Removed changes created by VSCode ESLint extension * Update src/style/style_image.js * object to Object and ryan's nits * Update src/ui/events.js Co-authored-by: Katy DeCorah <decorah@mapbox.com> * Update src/style/style_image.js Co-authored-by: Katy DeCorah <decorah@mapbox.com> * Update src/style/style_image.js Co-authored-by: Ricky Reusser <rreusser@users.noreply.github.com> * Update src/ui/events.js Co-authored-by: Ricky Reusser <rreusser@users.noreply.github.com> * Update src/ui/events.js Co-authored-by: Ricky Reusser <rreusser@users.noreply.github.com> Co-authored-by: Dom Brassey <dom.brassey@mapbox.com> Co-authored-by: Katy DeCorah <decorah@mapbox.com> Co-authored-by: Ricky Reusser <rreusser@users.noreply.github.com> * remove straggler instance of @Property {MapTouchEvent} data * change 2 tests from warn to error * Break down map methods and events into sections for docs (#10844) * add map source sections, reorder some methods * map sections fixes * Fix @section causing `jsdoc/require-description-complete-sentence` to fail * Cleanup reordered `events` Co-authored-by: Arindam Bose <arindam.bose@mapbox.com> * Apply suggestions from code review * Update src/ui/map.js * Update src/ui/map.js * Update src/ui/map.js * Update src/ui/map.js * Update src/source/vector_tile_source.js Co-authored-by: Dan Swick <dan.swick@gmail.com> * Update src/geo/transform.js Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com> Co-authored-by: Dom Brassey <dom.brassey@mapbox.com> Co-authored-by: Ansis Brammanis <ansis@mapbox.com> Co-authored-by: Karim Naaji <karim.naaji@gmail.com> Co-authored-by: Ryan Hamley <ryan.hamley@mapbox.com> Co-authored-by: Arindam Bose <arindam.bose@mapbox.com> Co-authored-by: Ricky Reusser <rreusser@users.noreply.github.com> Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com> Co-authored-by: Katy DeCorah <decorah@mapbox.com> Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com> Co-authored-by: Dan Swick <dan.swick@gmail.com>
arindam1993
pushed a commit
that referenced
this pull request
Jul 30, 2021
* mapeventdata --> mapdataevent * added require-property * change warns to fails * update tests * ALL THE TESTS * restore events.js * updates and upgrades * increase rigor of tests * fix eslint errors for jsdoc examples (#10847) * Add a few more examples (#10850) * Add a few examples * Update src/geo/mercator_coordinate.js Co-authored-by: Ansis Brammanis <ansis@mapbox.com> Co-authored-by: Ansis Brammanis <ansis@mapbox.com> * Add some docs example (#10859) * `require-example` linting (#10855) * Add geojson source examples * Add src/source/* inline examples * Linter * Lint * Add camera examples * Fixup * Add camera examples * Review comments * Minor nit * Apply jsdoc eslint rules only to public API files (#10854) * `require-example` linting (#10862) * Last public facing examples * Exclude private files from geo/ and promote require-example from warning to error * `jsdoc/newline-after-description` linting (#10863) * Update doc comments to conform to eslint-complete-sentences rule (#10851) * Update doc comments to conform to eslint-complete-sentences rule * Fix typo * more detailed docs for return `this` Extracted from Arindam's #10848 * Fix docs language * Make complete-sentences an error * Update eslintrc * Cleanup * Respond to feedback Co-authored-by: Ansis Brammanis <ansis@mapbox.com> * Non-test content updates (#10868) * GL-JS --> Mapbox GL JS * GL JS --> Mapbox GL JS * remove e.g. * remove i.e. * Update src/ui/camera.js * Resolves `eslint-plugin-jsdoc` test failures (#10858) * Adds 'resource type' prefix for related items in GL JS API docs (#10837) Co-authored-by: Asheem Mamoowala <asheem.mamoowala@mapbox.com> Co-authored-by: Heather Stenson <heather.stenson@mapbox.com> Co-authored-by: Karim Naaji <karim.naaji@gmail.com> Co-authored-by: Arindam Bose <arindam.bose@mapbox.com> Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com> * `jsdoc/check-types` linting (#10864) * `jsdoc/check-types` linting: `Object` -> `object` * Back to `Object` :| * remove tests: check-indentation, check-alignment, check-tag-names, no-bad-blocks, valid-types, require-throws * fix check-line-alignment and turn almost all tests to error * change require-param-type to warn and fix that pesky sentence * `jsdoc/require-param-type` linting (#10867) * `jsdoc/require-param-type` linting * Switch `Callback` to `Function` as per other callbacks defined in map.js * Pin chrome to version 91 (#10887) * Pin to chrome version 91 * Pin chrome version for test-browser Co-authored-by: Dom Brassey <dom.brassey@mapbox.com> * Add default values to some map API methods (#10823) * Add default values to map methods * Add default style value * Add customAttribution default * Add default value for container * do not represent container as optional with value null * do not represent style as optional with value null * capitalize first letter Co-authored-by: Dom Brassey <dom.brassey@mapbox.com> Co-authored-by: HeyStenson <heather.stenson@mapbox.com> * "jsdoc/require-property-description" rule and fixes to events.js (#10870) * Merging * Removed changes created by VSCode ESLint extension * Update src/style/style_image.js * object to Object and ryan's nits * Update src/ui/events.js Co-authored-by: Katy DeCorah <decorah@mapbox.com> * Update src/style/style_image.js Co-authored-by: Katy DeCorah <decorah@mapbox.com> * Update src/style/style_image.js Co-authored-by: Ricky Reusser <rreusser@users.noreply.github.com> * Update src/ui/events.js Co-authored-by: Ricky Reusser <rreusser@users.noreply.github.com> * Update src/ui/events.js Co-authored-by: Ricky Reusser <rreusser@users.noreply.github.com> Co-authored-by: Dom Brassey <dom.brassey@mapbox.com> Co-authored-by: Katy DeCorah <decorah@mapbox.com> Co-authored-by: Ricky Reusser <rreusser@users.noreply.github.com> * remove straggler instance of @Property {MapTouchEvent} data * change 2 tests from warn to error * Break down map methods and events into sections for docs (#10844) * add map source sections, reorder some methods * map sections fixes * Fix @section causing `jsdoc/require-description-complete-sentence` to fail * Cleanup reordered `events` Co-authored-by: Arindam Bose <arindam.bose@mapbox.com> * Apply suggestions from code review * Update src/ui/map.js * Update src/ui/map.js * Update src/ui/map.js * Update src/ui/map.js * Update src/source/vector_tile_source.js Co-authored-by: Dan Swick <dan.swick@gmail.com> * Update src/geo/transform.js Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com> Co-authored-by: Dom Brassey <dom.brassey@mapbox.com> Co-authored-by: Ansis Brammanis <ansis@mapbox.com> Co-authored-by: Karim Naaji <karim.naaji@gmail.com> Co-authored-by: Ryan Hamley <ryan.hamley@mapbox.com> Co-authored-by: Arindam Bose <arindam.bose@mapbox.com> Co-authored-by: Ricky Reusser <rreusser@users.noreply.github.com> Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com> Co-authored-by: Katy DeCorah <decorah@mapbox.com> Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com> Co-authored-by: Dan Swick <dan.swick@gmail.com>
SnailBones
added a commit
that referenced
this pull request
Aug 2, 2021
#10889) * addClassName method can be called before the popup is on map * Added tests * Updating incorrect examples * Added console.warn error messages for incorrect function use * Pin chrome to version 91 (#10887) * Pin to chrome version 91 * Pin chrome version for test-browser * Update src/ui/popup.js Co-authored-by: Ricky Reusser <rreusser@users.noreply.github.com> * Fixed asterisks for jsdoc * Removing else with early return * Updates to `flyTo` docs (#10890) * updates to flyto * no trailing spaces * Added _classList Set to Popup * Trim and split on any whitespace as Ricky suggested * Update documentation for @returns * Refactored so that changes to the container are always performed by _updateClassList * Inlining function from anchor.js to marker.js * Typo fix * Small changes from suggestions * Aadding ;s to examples Co-authored-by: Arindam Bose <arindam.bose@mapbox.com> Co-authored-by: Ricky Reusser <rreusser@users.noreply.github.com> Co-authored-by: Heather Stenson <heather.stenson@mapbox.com>
mourner
pushed a commit
that referenced
this pull request
Aug 9, 2021
* Pin to chrome version 91 * Pin chrome version for test-browser
mourner
added a commit
that referenced
this pull request
Aug 9, 2021
* refactor raw projections, handle projection options * add unprojection to winkel tripel * fix flow * Pin chrome to version 91 (#10887) * Pin to chrome version 91 * Pin chrome version for test-browser * fix lint * remove to superfluous sin calls Co-authored-by: Arindam Bose <arindam.bose@mapbox.com>
ansis
added a commit
that referenced
this pull request
Oct 19, 2021
* rough projection support * projections stencil clipping and refactor (#410) * Enable stencil clipping for line and fill layers * Use buffers from tile * Refactor tile bounds buffers * Rename things to not exclusively be RasterBounds * Create projections directory * More refactoring * Combine matrix calculations * Cleanup * Refactor projections to new folder * Begin debug work * Tile boundaries are working * Refactor indexbuffer and segmentvector to per painter * merge projectx and projecty functions * nits Co-authored-by: Ansis Brammanis <ansis@mapbox.com> * Projections fix location issues (#414) * Add debug page * Add projection option * Wire up projection code with worker * Rename projections folder to projection * Refactor and update free camera * Add Projection type and fix center calculations * Fix bug with transform._center * Make Winkel projection noop for now * Update demo HTML and CSS * temp remove undistortion Co-authored-by: Ansis Brammanis <ansis@mapbox.com> * [projections] Adaptive geometry resampling for alternative projections (#10753) * implement adaptive resampling of reprojected geometry * address feedback * Refactor projections code to get all tests passing (#10732) * [projections] Simplify and optimize tile transform code (#10780) * simplify projections tile transform * skip resampling for mercator * [projections] Fix performance regression in draw_background (#10747) * separate tiles for background layers * additional lint & flow fixes * try fixing tests * try fixing render tests Co-authored-by: Ansis Brammanis <ansis@mapbox.com> * Pin chrome to version 91 (#10887) (#10896) * Pin to chrome version 91 * Pin chrome version for test-browser Co-authored-by: Arindam Bose <arindam.bose@mapbox.com> * Refactor raw projections, handle projection options (#10913) * refactor raw projections, handle projection options * add unprojection to winkel tripel * fix flow * Pin chrome to version 91 (#10887) * Pin to chrome version 91 * Pin chrome version for test-browser * fix lint * remove to superfluous sin calls Co-authored-by: Arindam Bose <arindam.bose@mapbox.com> * Fix bearing for non-mercator projections (#10781) * Use adaptive resampling with MARTINI & Earcut for non-Mercator tiles (#10980) * use adaptive resampling and earcut for non-Mercator tile bounds * fix unit test * use adaptive MARTINI mesh for non-Mercator raster tiles * Clamp unproject to valid geo range in alternate projections (#10992) * clamp unproject to mercator bounds in all projections * fix marker test * avoid wrapping center for non-Mercator projections * extend alt projections clamping to full lat range * correct zoom, bearing and shear for projections (#10976) * fix zoom, bearing and skew for projections * refactor adjustments * lint * add comments * Fix circle and heatmap on alternate projections (#11074) * fix circle & heatmap on alternate projections (blunder) * fix unit test * fix pitch, line-width and other properties for projections (#11080) and: - fix fill-extrusions - remove global projection variable to allow multiple maps on one page - avoid recalculating tileTransform * Add Equal Earth, Natural Earth and Lambert Conformal Conic projections (#11091) * Fix constraining logic for alternate projections (#11092) * adaptive bbox for projections, refactor resampling * better precision for adaptive bounds * remove leftover * fix zoom/shear adjustments near poles * optimize tile transform * fix lint * attempt to fix tests * simplify, clarify and consolidate constraining logic * minor renames in transform * safer clamping for zoom adjustments * Projections public API (#11002) Co-authored-by: Ansis Brammanis <ansis@mapbox.com> * fix conflicts * fix seams around alternate-projected tiles (#11119) * fix unit tests * remove alaska * Basic support for custom maxBounds in alternate projections (#11121) * rudimentary support for custom maxBounds in alternate projections * fix flow * fix image and video sources in alternate projections (#11123) * clean up debug pages * remove uncessary deg <--> rad conversions * fix filename casing * fix queryRenderedFeatures for alternate projections (#11125) * Projections fixups (#11127) * disable terrain and fog for alternate projections (#11126) * Lazily instantiate projected tile debug buffers and release projected buffers when tiles are unloaded (#11128) * enable lod tile loading for projections (#11129) * enable lod tile loading for projections to significantly reduce the number of tiles at low zoom levels * use Math.hypot(...) Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com> * add comments Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com> * allow map.setProjection(null) * add limitations * avoid recreating tile buffer Co-authored-by: Karim Naaji <karim.naaji@gmail.com> * fix assertion error * fix requires * center projections vertically Center projections vertically in 0 to 1 range. This shouldn't matter but there is some constraining behavior that is currently affected by this. * Fix tile buffer destroyed but not reset (#11134) * mention settin bounds in projection docs Co-authored-by: Ryan Hamley <ryan.hamley@mapbox.com> Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com> Co-authored-by: Arindam Bose <arindam.bose@mapbox.com> Co-authored-by: Karim Naaji <karim.naaji@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome version 92 seems to not want to launch and is causing tests to time out this PR pins it to version 91.