Updates to flyTo docs
#10890
Merged
Updates to flyTo docs
#10890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhamley
approved these changes
Jul 21, 2021
SnailBones
pushed a commit
that referenced
this pull request
Jul 22, 2021
SnailBones
pushed a commit
that referenced
this pull request
Jul 26, 2021
SnailBones
added a commit
that referenced
this pull request
Aug 2, 2021
#10889) * addClassName method can be called before the popup is on map * Added tests * Updating incorrect examples * Added console.warn error messages for incorrect function use * Pin chrome to version 91 (#10887) * Pin to chrome version 91 * Pin chrome version for test-browser * Update src/ui/popup.js Co-authored-by: Ricky Reusser <rreusser@users.noreply.github.com> * Fixed asterisks for jsdoc * Removing else with early return * Updates to `flyTo` docs (#10890) * updates to flyto * no trailing spaces * Added _classList Set to Popup * Trim and split on any whitespace as Ricky suggested * Update documentation for @returns * Refactored so that changes to the container are always performed by _updateClassList * Inlining function from anchor.js to marker.js * Typo fix * Small changes from suggestions * Aadding ;s to examples Co-authored-by: Arindam Bose <arindam.bose@mapbox.com> Co-authored-by: Ricky Reusser <rreusser@users.noreply.github.com> Co-authored-by: Heather Stenson <heather.stenson@mapbox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8712
This PR updates the wording for
flyTo'scurveandminZoomoptions to specify that acurvevalue will not be respected ifminZoomis provided. If someone from @mapbox/gl-js could review, I'd appreciate it!