This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 116
Expose LocationIndicatorLayer and an alternative rendering mode based on it #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
commented
Apr 10, 2020
...droidSDK/src/main/java/com/mapbox/mapboxsdk/location/LocationComponentActivationOptions.java
Outdated
Show resolved
Hide resolved
LukasPaczos
force-pushed
the
lp-location-layer-2
branch
from
April 14, 2020 11:26
18fab89
to
586b739
Compare
LukasPaczos
force-pushed
the
lp-location-layer-2
branch
from
April 14, 2020 17:39
b9c0379
to
e053c3f
Compare
chloekraw
reviewed
Apr 15, 2020
...droidSDK/src/main/java/com/mapbox/mapboxsdk/location/LocationComponentActivationOptions.java
Outdated
Show resolved
Hide resolved
...droidSDK/src/main/java/com/mapbox/mapboxsdk/location/LocationComponentActivationOptions.java
Outdated
Show resolved
Hide resolved
...droidSDK/src/main/java/com/mapbox/mapboxsdk/location/LocationComponentActivationOptions.java
Show resolved
Hide resolved
...droidSDK/src/main/java/com/mapbox/mapboxsdk/location/LocationComponentActivationOptions.java
Outdated
Show resolved
Hide resolved
LukasPaczos
force-pushed
the
lp-location-layer-2
branch
3 times, most recently
from
April 15, 2020 12:28
983f9c6
to
3e1b238
Compare
tobrun
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
There are still 2 PRs in flight that I'm waiting for before merging - mapbox/mapbox-gl-native#16400 and mapbox/mapbox-gl-native#16404. If needed, we could also merge this PR and release an alpha without the location click support that relies on mapbox/mapbox-gl-native#16400 and follow up in the next pre-release. |
LukasPaczos
force-pushed
the
lp-location-layer-2
branch
from
April 20, 2020 16:17
3e1b238
to
9e01c27
Compare
Changelog entry is below @chloekraw if you want to give it a pass.
Otherwise, I bumped all of the deps and I'll merge tomorrow after QA. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes a new
LocationComponent
's rendering mode that can be activated using the options flag:The flag defaults to
false
, but when set, it uses a dedicated layer to render the puck instead of using the stack symbol and circle layers. The specialized implementation is fully compatible with the traditional impl, except for:FOREGROUND_LAYER
orLOCATION_SOURCE
which are either no-op or return different types in this mode.LocationComponentOptions#foregroundName
are ignored. There's a simple alternative in the form ofLocationComponentOptions#foregroundDrawable
and other though.This branch is currently based on mapbox/mapbox-gl-native#16388 and also requires a fix from mapbox/mapbox-gl-native#16391 to be completely stable. When all those changes are released, I'll retarget the submodule pin.
TODO:
IndicatorLocationLayerRenderer
tests./cc @chloekraw @galinelle