This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
When removing an image use the correct list ptr for presence verification #16391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
added
the
needs changelog
…tion This fixes an issues where calling `removeImage` would crash if the image was not present and the original list was not empty.
LukasPaczos
force-pushed
the
lp-fix-doubled-image-removal
branch
from
6edd82a
to
8609c4a
Compare
LukasPaczos
removed
the
needs changelog
galinelle
approved these changes
Apr 10, 2020
|
This needs a unit test /cc @tmpsantos |
|
Adding the test in #16392. |
LukasPaczos
added a commit
that referenced
this pull request
Apr 10, 2020
LukasPaczos
added a commit
that referenced
this pull request
Apr 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issues where calling
removeImagewould crash if the image was not present and the original images list was not empty.Launch Checklist
needs changeloglabel if a changelog is needed (remove label when added)