This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
WIP - Style.java #10971
Closed
WIP - Style.java #10971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
added
Android
tobrun
force-pushed
the
tvn-style-public-api
branch
3 times, most recently
from
65a5bbe
to
0c4a902
Compare
tobrun
force-pushed
the
tvn-style-public-api
branch
from
0c4a902
to
2fcec02
Compare
tobrun
force-pushed
the
tvn-style-public-api
branch
from
2fcec02
to
f588815
Compare
|
Hit some bumps while working on the C++ part of this PR, will need some additional eyes. |
|
I closed this PR due to other priorities moving for v6.0.0. Capturing from internal conversations that this might still happen as part of a 6.x release later on (we can deprecate the old methods and reroute them through the new Style.java api). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from core PR in #9280, closes #9338 & closes #10947.
This PR introduces the concept of Style as conform to what core exposes as public API in style.hpp. Atm this PR is still a WIP, the following items need to be resolved before reviewing:
Style.java, migrate methods fromMapboxMap.javaStyleConstants.javaand provide integration inStyle.javaStyle.javainstead of round-trippingNativeMapView.javaStyle.javatostylepackage instead ofmaps(blocked by above)cc @mapbox/maps-android