[ios] adapt Mapbox Streets–sourced layers for user preferred language #9582

fabian-guerra · 2017-07-21T21:18:04Z

friedbunny · 2017-07-21T21:46:26Z

platform/ios/src/MGLMapView.mm

+
+- (void)updateLocalization
+{
+    NSString *mapboxLanguage = [[NSUserDefaults standardUserDefaults] stringForKey:@"MGLMapboxLanguage"];


I’m not sure NSUserDefaults is appropriate here — it’s possible that a user will load a map, we will localize it once, then the app will eventually be killed. When the app restarts, we would not relocalize the map because the key was never reset.

Instead, I think an ivar might work better.

friedbunny · 2017-07-21T21:49:08Z

platform/ios/src/MGLMapView.mm

+        mapboxLanguage = preferredLanguageCode;
+        [[NSUserDefaults standardUserDefaults] setObject:mapboxLanguage forKey:@"MGLMapboxLanguage"];
+        [self setLabelLanguage:mapboxLanguage];
+        [[NSNotificationCenter defaultCenter] postNotificationName:NSCurrentLocaleDidChangeNotification object:nil];


Posting this notification is the system’s responsibility, isn’t it? If we want to post a notification about the map’s language changing, it would need to be scoped to our framework.

Additionally, we may want to listen for this notification and adjust the map’s localization accordingly.

@friedbunny I agree on posting a Mapbox scoped notification. Changing the language preferences makes the OS to restart, we don't get this notification NSCurrentLocaleDidChangeNotification

I mentioned NSCurrentLocaleDidChangeNotification mainly because it’s possible to change the preferred languages without restarting on macOS. I figured this feature would go in the cross-platform code in MGLStyle rather than MGLMapView.

friedbunny · 2017-07-21T21:53:45Z

platform/ios/src/MGLMapView.mm

    }
 }

+- (NSString *)preferredLanguageCode {
+    // Languages supported by Mapbox Streets v10.


streets-v10 is the style, but the deciding factor for language support is the vector tile source, which is (confusingly) called mapbox-streets-v7.

friedbunny · 2017-07-21T21:56:12Z

platform/ios/src/MGLMapView.mm

    }
 }

+- (NSString *)preferredLanguageCode {
+    // Languages supported by Mapbox Streets v10.
+    NSSet *supportedLanguages = [NSSet setWithObjects:@"en", @"es", @"fr", @"de", @"ru", @"zh", nil];


This is missing ar, pt, and zh-Hans. See the docs for mapbox-streets-v7 and this help doc for more information.

1ec5

There’s nothing specific to iOS about this feature, so we should seek to implement it in cross-platform code if possible. I think -[MGLStyle initWithRawStyle:mapView:] would be a good entry point for this feature.

Incidentally, this feature is already implemented at the application level in macosapp. If you haven’t already taken a look at it, I’d encourage you to consider how it accounts for variables like non-Streets layers:

mapbox-gl-native/platform/macos/app/MapDocument.m

Lines 346 to 393 in f053feb

    
           - (void)updateLabels { 
        
               MGLStyle *style = self.mapView.style; 
        
               NSString *preferredLanguage = _isLocalizingLabels ? [MGLVectorSource preferredMapboxStreetsLanguage] : nil; 
        
               NSMutableDictionary *localizedKeysByKeyBySourceIdentifier = [NSMutableDictionary dictionary]; 
        
               for (MGLSymbolStyleLayer *layer in style.layers) { 
        
                   if (![layer isKindOfClass:[MGLSymbolStyleLayer class]]) { 
        
                       continue; 
        
                   } 
        
                   MGLVectorSource *source = (MGLVectorSource *)[style sourceWithIdentifier:layer.sourceIdentifier]; 
        
                   if (![source isKindOfClass:[MGLVectorSource class]] || !source.mapboxStreets) { 
        
                       continue; 
        
                   } 
        
                   NSDictionary *localizedKeysByKey = localizedKeysByKeyBySourceIdentifier[layer.sourceIdentifier]; 
        
                   if (!localizedKeysByKey) { 
        
                       localizedKeysByKey = localizedKeysByKeyBySourceIdentifier[layer.sourceIdentifier] = [source localizedKeysByKeyForPreferredLanguage:preferredLanguage]; 
        
                   } 
        
                   NSString *(^stringByLocalizingString)(NSString *) = ^ NSString * (NSString *string) { 
        
                       NSMutableString *localizedString = string.mutableCopy; 
        
                       [localizedKeysByKey enumerateKeysAndObjectsUsingBlock:^(NSString * _Nonnull key, NSString * _Nonnull localizedKey, BOOL * _Nonnull stop) { 
        
                           NSAssert([key isKindOfClass:[NSString class]], @"key is not a string"); 
        
                           NSAssert([localizedKey isKindOfClass:[NSString class]], @"localizedKey is not a string"); 
        
                           [localizedString replaceOccurrencesOfString:[NSString stringWithFormat:@"{%@}", key] 
        
                                                            withString:[NSString stringWithFormat:@"{%@}", localizedKey] 
        
                                                               options:0 
        
                                                                 range:NSMakeRange(0, localizedString.length)]; 
        
                       }]; 
        
                       return localizedString; 
        
                   }; 
        
                   if ([layer.text isKindOfClass:[MGLConstantStyleValue class]]) { 
        
                       NSString *textField = [(MGLConstantStyleValue<NSString *> *)layer.text rawValue]; 
        
                       layer.text = [MGLStyleValue<NSString *> valueWithRawValue:stringByLocalizingString(textField)]; 
        
                   } 
        
                   else if ([layer.text isKindOfClass:[MGLCameraStyleFunction class]]) { 
        
                       MGLCameraStyleFunction *function = (MGLCameraStyleFunction<NSString *> *)layer.text; 
        
                       NSMutableDictionary *stops = function.stops.mutableCopy; 
        
                       [stops enumerateKeysAndObjectsUsingBlock:^(NSNumber *zoomLevel, MGLConstantStyleValue<NSString *> *stop, BOOL *done) { 
        
                           NSString *textField = stop.rawValue; 
        
                           stops[zoomLevel] = [MGLStyleValue<NSString *> valueWithRawValue:stringByLocalizingString(textField)]; 
        
                       }]; 
        
                       function.stops = stops; 
        
                       layer.text = function; 
        
                   } 
        
               } 
        
           }

https://github.com/mapbox/mapbox-gl-native/blob/f053feb6d4aba1eaa44a35d050522b641c011b33/platform/macos/app/MGLVectorSource+MBXAdditions.m

Finally, there needs to be either an opt-in mechanism or an out-out mechanism for this feature. Sometimes a style is intentionally designed for a particular language. Where should such an option live?

1ec5 · 2017-07-23T04:47:26Z

platform/ios/src/MGLMapView.mm

+            continue;
+        }
+
+        if ([layer.text isKindOfClass:[MGLConstantStyleValue class]]) {


We should only attempt to modify layers that draw from the Mapbox Streets source. A developer should be able to add a shape or vector source using their own custom data with a name field and not have MGLMapView attempt to “localize” it to a nonexistent name_fr field.

1ec5 · 2017-07-23T04:49:54Z

platform/ios/src/MGLMapView.mm

@@ -1128,9 +1128,68 @@ - (void)wakeGL:(__unused NSNotification *)notification
        [self validateLocationServices];

        [MGLMapboxEvents pushEvent:MGLEventTypeMapLoad withAttributes:@{}];
+
+        [self updateLocalization];


If the developer switches to a new style while the application is already in the foreground, the labels won’t be localized until the user switches away and back to the application. Instead, we should localize the labels in response to -mapView:didFinishLoadingStyle:, as MapDocument does in macosapp.

Additionally, if the developer adds a named symbol layer after loading the style, using the runtime styling API, we should localize it consistently. If we’re concerned about that possibility, we could require a change to either -[MGLSymbolStyleLayer setText:] or -[MGLStyle addLayer:].

1ec5 · 2017-07-23T04:50:54Z

platform/ios/src/MGLMapView.mm

+        mapboxLanguage = preferredLanguageCode;
+        [[NSUserDefaults standardUserDefaults] setObject:mapboxLanguage forKey:@"MGLMapboxLanguage"];
+        [self setLabelLanguage:mapboxLanguage];
+        [[NSNotificationCenter defaultCenter] postNotificationName:NSCurrentLocaleDidChangeNotification object:nil];


We shouldn’t be posting a notification at all; instead, we should observe for NSCurrentLocaleDidChangeNotification.

1ec5 · 2017-07-23T04:52:27Z

platform/ios/src/MGLMapView.mm

+        mapboxLanguage = preferredLanguageCode;
+        [[NSUserDefaults standardUserDefaults] setObject:mapboxLanguage forKey:@"MGLMapboxLanguage"];
+        [self setLabelLanguage:mapboxLanguage];
+        [[NSNotificationCenter defaultCenter] postNotificationName:NSCurrentLocaleDidChangeNotification object:nil];


I mentioned NSCurrentLocaleDidChangeNotification mainly because it’s possible to change the preferred languages without restarting on macOS. I figured this feature would go in the cross-platform code in MGLStyle rather than MGLMapView.

friedbunny

I don’t see any way for the localization to be kept in sync with the platform language — is that coming or is there something about this implementation that makes that unnecessary?
This obviates the current example implementations in iosapp/macapp — let’s update those to use this.

friedbunny · 2017-07-25T22:57:27Z

platform/darwin/src/MGLStyle.h

+ it will look for the Preferred Language Order setting in the Language & Region section of Settings. 
+ If it doesn't fing a match it will fall back to english localization.
+ */
+@property (nonatomic, getter=isLocalizingLabels) BOOL localizingLabels;


@1ec5 will have a better grasp of platform conventions, but the verb tense of localizingLabels feels off to me. More standard would be localizeLabels, I think.

The correct tense here would be localizesLabels; there’s no need for a custom getter name in that case.

friedbunny · 2017-07-25T23:04:46Z

platform/darwin/src/MGLStyle.h

+ Set to true to determine the localization according to the languages
+ supported by <a href="https://www.mapbox.com/vector-tiles/mapbox-streets-v7/#overview">Mapbox Streets</a>, 
+ it will look for the Preferred Language Order setting in the Language & Region section of Settings. 
+ If it doesn't fing a match it will fall back to english localization.


This is a good start. A few notes:

Wrap at 80 characters, if possible.

I’m not sure if we follow this everywhere, but to avoid the Swift/ObjC true/YES issue, we can choose different words, like “enable”.

I would make it more clear that we’re looking at the platform’s language setting — it might be good to toss in a “system’s” or “platform” qualifier somewhere. This is a darwin header, so it may be trickier.

Make it clear that the Mapbox Streets in this case is the vector tile source, not the style of the same name.

What happens if the style does not have the Mapbox Streets source?

What happens if the style does not have the Mapbox Streets source?

None of the style layers would pass this test, so there would be no effect on the style.

fabian-guerra · 2017-07-25T23:34:55Z

@friedbunny on iOS we can't get the notification when there is a change in the system's language preferences. The developer will have to implements this in didFinishLoadingStyle.

1ec5

Remember to update the iOS and macOS changelogs.

1ec5 · 2017-07-26T06:35:14Z

platform/darwin/src/MGLStyle.mm

+{
+    _localizeLabels = localizeLabels;
+
+    if (_localizeLabels) {


Normally, a custom setter checks whether the old value is equal to the new value. If it is, the setter returns early because there’s nothing to do.

1ec5 · 2017-07-26T06:40:37Z

platform/darwin/src/MGLStyle.h

+ href="https://www.mapbox.com/vector-tiles/mapbox-streets-v7/#overview">
+ Mapbox Streets</a>, it will look for the Preferred Language Order setting in
+ the system's Language & Region section of Settings. If it doesn't find a
+ match it will fall back to english localization.


A Boolean value that determines whether the style attempts to localize labels in the style into the system’s preferred language.

When this property is enabled, the style automatically modifies the text property of any symbol style layer whose source is the Mapbox Streets source. On iOS, the user can set the system’s preferred language in Settings, General Settings, Language & Region. On macOS, the user can set the system’s preferred language in the Language & Region pane of System Preferences.

This property will currently only take effect in/after -mapView:didFinishLoadingStyle: — if this remains a limitation, we need to make that clear in the docs.

1ec5 · 2017-07-26T07:00:53Z

platform/darwin/src/MGLStyle.mm

+                layer.text = function;
+            }
+        }
+    }


What happens if the developer disables label localization when the layers are already localized? I think the developer would expect each layer to return to its original state as defined by the style JSON.

friedbunny · 2017-07-26T21:05:59Z

platform/ios/app/MBXViewController.m

-        @"country-label-sm",
-    ];
-    [self styleLabelLanguageForLayersNamed:labelLayers];
+    [self.mapView.style setLocalizeLabels:YES];


Along the lines of this comment, this should be converted to an on/off toggle.

friedbunny · 2017-07-26T21:13:27Z

platform/darwin/src/MGLStyle.h

+ the system's Language & Region section of Settings. If it doesn't find a
+ match it will fall back to english localization.
+ */
+@property (nonatomic, getter=isLocalizeLabels) BOOL localizeLabels;


isLocalizingLabels was probably OK here, if we care about grammar. 😆

friedbunny · 2017-07-26T21:24:26Z

platform/ios/app/MBXViewController.m

-        }
-    }
-}
-


Should we also replace/remove -bestLanguageForUser?

@friedbunny We could but in the MBXViewController we would have to explicitly import "MGLVectorSource+MBXAdditions.h" is that ok?

As long as -bestLanguageForUser matches the implementation of MGLVectorSource.preferredMapboxStreetsLanguage, there should be no need to make that header public to import it. Displaying the language that would be used is a pretty narrow use case that I wouldn’t expect any other application to need.

@friedbunny @1ec5 it does matches the implementation so I don't think we need to get rid of this.

friedbunny · 2017-07-26T21:26:35Z

platform/darwin/src/MGLStyle.h

+ href="https://www.mapbox.com/vector-tiles/mapbox-streets-v7/#overview">
+ Mapbox Streets</a>, it will look for the Preferred Language Order setting in
+ the system's Language & Region section of Settings. If it doesn't find a
+ match it will fall back to english localization.


This property will currently only take effect in/after -mapView:didFinishLoadingStyle: — if this remains a limitation, we need to make that clear in the docs.

friedbunny · 2017-07-26T21:30:30Z

platform/darwin/src/MGLStyle.h

@@ -610,6 +610,18 @@ MGL_EXPORT
 */
 @property (nonatomic, strong) MGLLight *light;

+#pragma mark Managing Style's localization


I’m not sure how we landed on “Managing” everything. 🤔 Could we just call this “Localization”?

friedbunny · 2017-07-26T21:38:15Z

@friedbunny on iOS we can't get the notification when there is a change in the system's language preferences. The developer will have to implements this in didFinishLoadingStyle.

This code also operates on macOS — does the notification appear on that platform?

fabian-guerra · 2017-07-26T23:54:54Z

@friedbunny it does appear on MacOS. That could be tail work, now both platforms are consistent on localization update only by request.

1ec5 · 2017-07-27T07:53:10Z

platform/ios/ios.xcodeproj/project.pbxproj

@@ -17,6 +17,10 @@
 		1F7454971ECD450D00021D39 /* MGLLight_Private.h in Headers */ = {isa = PBXBuildFile; fileRef = 1F7454941ECD450D00021D39 /* MGLLight_Private.h */; };
 		1F7454A91ED08AB400021D39 /* MGLLightTest.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1F7454A61ED08AB400021D39 /* MGLLightTest.mm */; };
 		1F95931D1E6DE2E900D5B294 /* MGLNSDateAdditionsTests.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1F95931C1E6DE2E900D5B294 /* MGLNSDateAdditionsTests.mm */; };
+		1FDD9D6F1F26936400252B09 /* MGLVectorSource+MBXAdditions.h in Headers */ = {isa = PBXBuildFile; fileRef = 1FDD9D6D1F26936400252B09 /* MGLVectorSource+MBXAdditions.h */; };


The MBX class prefix is used for the example applications, while the MGL class prefix is used for the SDK itself.

1ec5 · 2017-07-27T07:59:10Z

platform/ios/app/MBXViewController.m

-        }
-    }
-}
-


As long as -bestLanguageForUser matches the implementation of MGLVectorSource.preferredMapboxStreetsLanguage, there should be no need to make that header public to import it. Displaying the language that would be used is a pretty narrow use case that I wouldn’t expect any other application to need.

friedbunny

LGTM, provided we ticket out tail work like delocalization and NSCurrentLocaleDidChangeNotification.

1ec5 · 2017-07-28T07:40:28Z

platform/darwin/src/MGLStyle.h

@@ -610,6 +610,21 @@ MGL_EXPORT
 */
 @property (nonatomic, strong) MGLLight *light;

+#pragma mark Style's localization


For consistency in jazzy documentation, marks in headers should be in title case and should describe a task:

Localizing Map Content

1ec5 · 2017-07-28T07:43:46Z

platform/darwin/src/MGLStyle.mm

+    } else {
+        for (NSString *identifier in self.localizedLayersByIdentifier) {
+            MGLSymbolStyleLayer *layer = (MGLSymbolStyleLayer *)[self.mapView.style layerWithIdentifier:identifier];
+            NSDictionary *languages = [self.localizedLayersByIdentifier objectForKey:identifier];


We can avoid this lookup by calling -[NSDictionary enumerateKeysAndObjectsUsingBlock:] instead of using a for-in loop.

1ec5 · 2017-07-28T07:45:34Z

platform/darwin/src/MGLStyle.mm

+        for (NSString *identifier in self.localizedLayersByIdentifier) {
+            MGLSymbolStyleLayer *layer = (MGLSymbolStyleLayer *)[self.mapView.style layerWithIdentifier:identifier];
+            NSDictionary *languages = [self.localizedLayersByIdentifier objectForKey:identifier];
+            NSString *originalLanguage = [languages allKeys].firstObject;


The NSDictionary.allKeys documentation states:

The order of the elements in the array is not defined.

Therefore this code makes an assumption that there’s only one key-value pair in the dictionary, of the form oldText = newText. If that fact ever changes, this code would have non-deterministic behavior.

1ec5 · 2017-07-28T07:57:14Z

platform/darwin/src/MGLStyle.mm

+                    NSString *textField = stop.rawValue;
+                    NSString *localizingString = stringByLocalizingString(textField);
+                    if (![textField isEqualToString:localizingString]) {
+                        [self.localizedLayersByIdentifier setObject:@{ textField : localizingString } forKey:layer.identifier];


If there are multiple stops, each with a different value, only the last stop’s value would be associated with this layer in localizedLayersByIdentifier. If a style function has {name_en} at some zoom levels but {name_en} ({name}) at others, only one value will be remembered for when localization is disabled. This scenario could become a lot more common when expressions are implemented (#8074).

1ec5 · 2017-07-28T07:59:33Z

platform/ios/CHANGELOG.md

@@ -7,6 +7,7 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT
 * Reduced the size of the dynamic framework by optimizing symbol visibility. ([#7604](https://github.com/mapbox/mapbox-gl-native/pull/7604))
 * Fixed an issue where the attribution button would have its custom tint color reset when the map view received a tint color change notification, such as when an alert controller was presented. ([#9598](https://github.com/mapbox/mapbox-gl-native/pull/9598))
 * Improved the behavior of zoom gestures when the map reaches the minimum zoom limit. ([#9626](https://github.com/mapbox/mapbox-gl-native/pull/9626))
+* Added support to adapt Mapbox Streets–sourced layers for user preferred language. ([#9582](https://github.com/mapbox/mapbox-gl-native/pull/9582))


Let’s be a bit more specific:

Added an MGLStyle.localizesLabels property, off by default, that localizes any Mapbox Streets–sourced symbol layer into the user’s preferred language.

1ec5 · 2017-07-28T08:01:49Z

platform/macos/app/MapDocument.m

-            layer.text = function;
-        }
-    }
+    [self.mapView.style setLocalizesLabels:YES];


This method should account for _isLocalizingLabels. Otherwise, the View ‣ Labels In ‣ Local Language menu item has no effect.

1ec5 · 2017-07-28T08:04:42Z

platform/ios/app/MBXViewController.m

-        @"country-label-sm",
-    ];
-    [self styleLabelLanguageForLayersNamed:labelLayers];
+    [self.mapView.style setLocalizesLabels:YES];


This method should account for _usingLocaleBasedCountryLabels. Otherwise, the “Label Countries in Local Language” option has no effect. Also, we should rename the option to “Show Labels in ”, because MGLStyle.localizesLabels localizes everything, not just country labels.

1ec5 · 2017-07-28T08:05:00Z

platform/ios/app/MBXViewController.m

-        @"country-label-sm",
-    ];
-    [self styleLabelLanguageForLayersNamed:labelLayers];
+    [self.mapView.style setLocalizesLabels:YES];


Nit: use dot syntax consistently: self.mapView.style.localizesLabels = YES.

boundsj · 2017-08-01T17:37:33Z

platform/darwin/src/MGLStyle.mm

+/**
+ Model class for localization changes.
+ */
+@interface __MGLTextLanguage: NSObject


I would prefer not to introduce this convention since I don't think we've used it for any other similar cases.

boundsj

Apart from the __ convention used to name the new internal class __MGLTextLanguage this looks good to me and I think this can be merged.

The comments were addressed in the last commit

1ec5 · 2018-04-11T16:48:23Z

LGTM, provided we ticket out tail work like delocalization and NSCurrentLocaleDidChangeNotification.

#11660

fabian-guerra requested review from boundsj, friedbunny and 1ec5 July 21, 2017 21:18

friedbunny reviewed Jul 21, 2017

View reviewed changes

friedbunny added feature iOS Mapbox Maps SDK for iOS localization Human language support and internationalization labels Jul 21, 2017

1ec5 previously requested changes Jul 23, 2017

View reviewed changes

fabian-guerra self-assigned this Jul 24, 2017

fabian-guerra force-pushed the fabian-adapt-user-language-7031 branch 2 times, most recently from a3b518a to cc69672 Compare July 24, 2017 22:52

friedbunny reviewed Jul 25, 2017

View reviewed changes

1ec5 reviewed Jul 26, 2017

View reviewed changes

friedbunny added this to the ios-v3.6.1 milestone Jul 26, 2017

friedbunny reviewed Jul 26, 2017

View reviewed changes

1ec5 reviewed Jul 27, 2017

View reviewed changes

fabian-guerra force-pushed the fabian-adapt-user-language-7031 branch from 9ebf34e to 5a72965 Compare July 27, 2017 16:52

friedbunny approved these changes Jul 27, 2017

View reviewed changes

fabian-guerra force-pushed the fabian-adapt-user-language-7031 branch from 5a72965 to f10c9a6 Compare July 27, 2017 22:21

1ec5 reviewed Jul 28, 2017

View reviewed changes

jmkiley mentioned this pull request Jul 28, 2017

Localization plugin mapbox/mapbox-plugins-ios#2

Closed

fabian-guerra force-pushed the fabian-adapt-user-language-7031 branch from 7b316cf to 126162f Compare July 31, 2017 22:14

friedbunny modified the milestones: ios-v3.6.2, ios-v3.6.1 Aug 1, 2017

fabian-guerra force-pushed the fabian-adapt-user-language-7031 branch from 126162f to 6abfbac Compare August 1, 2017 14:34

boundsj reviewed Aug 1, 2017

View reviewed changes

boundsj approved these changes Aug 1, 2017

View reviewed changes

fabian-guerra force-pushed the fabian-adapt-user-language-7031 branch from 6abfbac to 7a07856 Compare August 1, 2017 17:48

fabian-guerra added 9 commits August 1, 2017 15:43

[ios] Update label localization

6a1c515

[ios, macos] Move MGLVectorSource+MBXAdditions.h to darwin.

6b36d60

[ios, macos] Adapt Mapbox Streets to the user preferred language.

8c2e18e

[ios, macos] Clarify style localization documentation.

d594986

[ios, macos] Update localization examples

f54923d

[ios, macos] Add style language reset to original.

110757c

[ios, macos] Update changelogs.

e42a599

[ios, macos] Rename Vector Source Additions to MGL standard.

5ececfb

[ios, macos] Add suport for stop localization.

2c77056

fabian-guerra force-pushed the fabian-adapt-user-language-7031 branch from 7a07856 to 2c77056 Compare August 1, 2017 19:44

fabian-guerra merged commit afd4df9 into release-ios-v3.6.0-android-v5.1.0 Aug 1, 2017

fabian-guerra deleted the fabian-adapt-user-language-7031 branch August 1, 2017 20:14

friedbunny mentioned this pull request Aug 2, 2017

Automatically localize to user preferred language mapbox/ios-sdk-examples#36

Closed

boundsj mentioned this pull request Aug 2, 2017

Automatically adapt Mapbox Streets–sourced layers for user preferred language #7031

Closed

1ec5 mentioned this pull request Aug 23, 2017

[ios, macos] Adapt Mapbox Streets–sourced layers for Dynamic Type. #9734

Closed

1ec5 mentioned this pull request Aug 31, 2017

Localize abbreviations when localizing labels #9902

Closed

1ec5 mentioned this pull request Apr 11, 2018

Automatically relocalize labels when system locale changes #11660

Closed

	- (void)updateLabels {
	MGLStyle *style = self.mapView.style;
	NSString *preferredLanguage = _isLocalizingLabels ? [MGLVectorSource preferredMapboxStreetsLanguage] : nil;
	NSMutableDictionary *localizedKeysByKeyBySourceIdentifier = [NSMutableDictionary dictionary];
	for (MGLSymbolStyleLayer *layer in style.layers) {
	if (![layer isKindOfClass:[MGLSymbolStyleLayer class]]) {
	continue;
	}

	MGLVectorSource source = (MGLVectorSource )[style sourceWithIdentifier:layer.sourceIdentifier];
	if (![source isKindOfClass:[MGLVectorSource class]] \|\| !source.mapboxStreets) {
	continue;
	}

	NSDictionary *localizedKeysByKey = localizedKeysByKeyBySourceIdentifier[layer.sourceIdentifier];
	if (!localizedKeysByKey) {
	localizedKeysByKey = localizedKeysByKeyBySourceIdentifier[layer.sourceIdentifier] = [source localizedKeysByKeyForPreferredLanguage:preferredLanguage];
	}

	NSString (^stringByLocalizingString)(NSString ) = ^ NSString * (NSString *string) {
	NSMutableString *localizedString = string.mutableCopy;
	[localizedKeysByKey enumerateKeysAndObjectsUsingBlock:^(NSString * _Nonnull key, NSString * _Nonnull localizedKey, BOOL * _Nonnull stop) {
	NSAssert([key isKindOfClass:[NSString class]], @"key is not a string");
	NSAssert([localizedKey isKindOfClass:[NSString class]], @"localizedKey is not a string");
	[localizedString replaceOccurrencesOfString:[NSString stringWithFormat:@"{%@}", key]
	withString:[NSString stringWithFormat:@"{%@}", localizedKey]
	options:0
	range:NSMakeRange(0, localizedString.length)];
	}];
	return localizedString;
	};

	if ([layer.text isKindOfClass:[MGLConstantStyleValue class]]) {
	NSString textField = [(MGLConstantStyleValue<NSString > *)layer.text rawValue];
	layer.text = [MGLStyleValue<NSString *> valueWithRawValue:stringByLocalizingString(textField)];
	}
	else if ([layer.text isKindOfClass:[MGLCameraStyleFunction class]]) {
	MGLCameraStyleFunction function = (MGLCameraStyleFunction<NSString > *)layer.text;
	NSMutableDictionary *stops = function.stops.mutableCopy;
	[stops enumerateKeysAndObjectsUsingBlock:^(NSNumber zoomLevel, MGLConstantStyleValue<NSString > stop, BOOL done) {
	NSString *textField = stop.rawValue;
	stops[zoomLevel] = [MGLStyleValue<NSString *> valueWithRawValue:stringByLocalizingString(textField)];
	}];
	function.stops = stops;
	layer.text = function;
	}
	}
	}

[ios] adapt Mapbox Streets–sourced layers for user preferred language #9582

[ios] adapt Mapbox Streets–sourced layers for user preferred language #9582

Conversation

fabian-guerra commented Jul 21, 2017 • edited Loading

friedbunny Jul 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

friedbunny Jul 21, 2017 • edited Loading

Choose a reason for hiding this comment

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

friedbunny left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabian-guerra commented Jul 25, 2017

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

friedbunny Jul 26, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabian-guerra Jul 26, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

friedbunny Jul 26, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

friedbunny commented Jul 26, 2017

fabian-guerra commented Jul 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

friedbunny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boundsj left a comment

Choose a reason for hiding this comment

1ec5 commented Apr 11, 2018

fabian-guerra commented Jul 21, 2017 •

edited

Loading

friedbunny Jul 21, 2017 •

edited

Loading

friedbunny Jul 21, 2017 •

edited

Loading

friedbunny left a comment •

edited

Loading

friedbunny Jul 26, 2017 •

edited

Loading

fabian-guerra Jul 26, 2017 •

edited

Loading

friedbunny Jul 26, 2017 •

edited

Loading