Feedback System #405
Merged
Feedback System #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
electrostat
commented
Oct 19, 2017
electrostat
commented
- create a feedback system to handle the creation of a feedback event
- include location collect, event updating, and event canceling
- started method creation for handling feedback events - need to test reroute solution and move on to update and cancel functionality
- added functionality for update and cancel methods - still needs testing and tweaking
electrostat
added
✓ ready for review
and removed
⚠️ DO NOT MERGE
- code now matches how reroute functions - may add handling of multiple feedback events at once later in the system
danesfeder
added a commit
that referenced
this pull request
Oct 28, 2017
* Add feedback dialog modal * Add fab for feedback and reverse countdown progress bar * < API 21 support for theme colors * Adjust for landscape layouts * Handle landscape layout with GridLayoutManager * Create click listener and callback to determine which feedback is clicked * Add updated feedback icons * Feedback System (#405) * Method Creation - started method creation for handling feedback events - need to test reroute solution and move on to update and cancel functionality * Add feedback types * Update + Cancel - added functionality for update and cancel methods - still needs testing and tweaking * Tweak code to match reroute - code now matches how reroute functions - may add handling of multiple feedback events at once later in the system * Checkstyle fix from conflict resolution - fixed sisngle line checkstyle issue * Fix merge conflict * Dismiss the dialog when an item is clicked * Remove item size check * Add feedback item and update how we send via service * Update bottomsheet toast * Feedback Queue Update - renamed method - added feedback location collect to onLocation listener - created new methods to handle updating feedback and reroute queues * Location -> RingBuffer - change from using Location in updateFeedbackQueue and updateRerouteQueue to using a Ringbuffer * Add event to queue + rerouteDate - change sessionstate method name to match variable - add feedbackevent to queue - update reroute date when creating sessionstate * Location Timestamps + EventLocation - make test data timestamps the current time for the events - use sessionstate.eventLocation to store location at time fo feedback event trigger * Set Feedback Created - force set of feedback created to event trigger - tested multiple events * FeedbackID + UserID fixes - send feedbackID to feedbackevent creation - obtain and send vendorID as User ID for feedbackevents * isMocked setting - set isMocked to appropriate setting based on conditions for feedbackevents * Update icons / telem * Return if location null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.