Feedback for Drop-In UI #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avigation-android into dan-bottomsheet-feedback
…avigation-android into dan-bottomsheet-feedback
* Method Creation - started method creation for handling feedback events - need to test reroute solution and move on to update and cancel functionality * Add feedback types * Update + Cancel - added functionality for update and cancel methods - still needs testing and tweaking * Tweak code to match reroute - code now matches how reroute functions - may add handling of multiple feedback events at once later in the system * Checkstyle fix from conflict resolution - fixed sisngle line checkstyle issue * Fix merge conflict
danesfeder
commented
Oct 23, 2017
|
|
||
| FeedbackEvent feedbackEvent = new FeedbackEvent(feedbackEventSessionState, feedbackSource); | ||
| // TODO set feedback type and description from the parameters based | ||
| // TODO - note: these should use default values if the values passed are empty |
There was a problem hiding this comment.
Default for feedbackType is FEEDBACK_TYPE_GENERAL and description is just empty String.
- renamed method - added feedback location collect to onLocation listener - created new methods to handle updating feedback and reroute queues
- change from using Location in updateFeedbackQueue and updateRerouteQueue to using a Ringbuffer
danesfeder
commented
Oct 23, 2017
| FeedbackEvent feedbackEvent = iterator.next(); | ||
| if (feedbackEvent.getSessionState().eventLocation() != null | ||
| && feedbackEvent.getSessionState().eventLocation().equals(locationBuffer.peekFirst()) | ||
| || TimeUtils.dateDiff(feedbackEvent.getSessionState().rerouteDate(), new Date(), TimeUnit.SECONDS) |
There was a problem hiding this comment.
Should we be checking the rerouteDate() here?
- change sessionstate method name to match variable - add feedbackevent to queue - update reroute date when creating sessionstate
- make test data timestamps the current time for the events - use sessionstate.eventLocation to store location at time fo feedback event trigger
- force set of feedback created to event trigger - tested multiple events
- send feedbackID to feedbackevent creation - obtain and send vendorID as User ID for feedbackevents
- set isMocked to appropriate setting based on conditions for feedbackevents
ericrwolfe
approved these changes
Oct 28, 2017
Grsmto
pushed a commit
to Grsmto/mapbox-navigation-android
that referenced
this pull request
Oct 30, 2017
…android into fix-build * 'master' of https://github.com/mapbox/mapbox-navigation-android: Fixes issue with bearing values not matching the amount of coordinates passed with the new route request (mapbox#435) Feedback for Drop-In UI (mapbox#383) Directions List Dropdown (mapbox#415) fixed location object in snapToRoute (mapbox#434) add location engine class name as parameter of the different nav events builder methods (mapbox#401) Dynamic reroute tolerance method (mapbox#428) Replace maneuver arrows and lanes (mapbox#362) # Conflicts: # libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationMetricsWrapper.java
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bottomsheet fragment for showing feedback UI during navigation:
Todo:
cc: @ericrwolfe