Dynamic reroute tolerance method #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2017 12:37
cammace
added
navigation-core
platform parity
1ec5
reviewed
Oct 27, 2017
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Nit: lots of blank lines here.
There was a problem hiding this comment.
lol fixed that, wanted to make sure I ported the turf function to MAS :)
cammace
added
✓ ready for review
and removed
⚠️ DO NOT MERGE
ericrwolfe
approved these changes
Oct 27, 2017
Grsmto
pushed a commit
to Grsmto/mapbox-navigation-android
that referenced
this pull request
Oct 30, 2017
…android into fix-build * 'master' of https://github.com/mapbox/mapbox-navigation-android: Fixes issue with bearing values not matching the amount of coordinates passed with the new route request (mapbox#435) Feedback for Drop-In UI (mapbox#383) Directions List Dropdown (mapbox#415) fixed location object in snapToRoute (mapbox#434) add location engine class name as parameter of the different nav events builder methods (mapbox#401) Dynamic reroute tolerance method (mapbox#428) Replace maneuver arrows and lanes (mapbox#362) # Conflicts: # libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationMetricsWrapper.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #305
This is logic ported over from the iOS side
Still need to move Turf.Nearest to MAS, finish writing test, clean up code, and test.