Inform delegate when canceling through eorvc #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
commented
Apr 20, 2018
| @@ -459,7 +459,7 @@ func defaultFeedbackHandlers(source: FeedbackSource = .user) -> (send: FeedbackV | |||
| endOfRoute.dismissHandler = { [weak self] (stars, comment) in | |||
| guard let rating = self?.rating(for: stars) else { return } | |||
| self?.routeController.setEndOfRoute(rating: rating, comment: comment) | |||
| self?.dismiss(animated: true, completion: nil) | |||
| self?.delegate?.mapViewControllerDidCancelNavigation(self!) | |||
There was a problem hiding this comment.
Perhaps we should add a new …didEndNavigation() delegate method? /cc @JThramer
There was a problem hiding this comment.
@frederoni instead of force unwrapping self, why not safely unwrap at the guard on line 460?
There was a problem hiding this comment.
@frederoni agreed, It's time. Although what about something like didEndNavigation(cancelled: Bool)?
There was a problem hiding this comment.
The optionally chained self? and delegate? is evaluated before self! so this could arguably be considered a safe unwrap. I preferred this way because we'd still want the feedback and the delegate to trigger rather than getting stuck in the guard.
JThramer
approved these changes
Apr 20, 2018
frederoni
force-pushed
the
fred/fix-exit-eorvc
branch
from
86d11ab
to
2b16f3d
Compare
frederoni
force-pushed
the
fred/fix-exit-eorvc
branch
from
d46c87f
to
f7b44f9
Compare
1ec5
added
the
backwards incompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dismissing a view controller only works if it was presented with a UINavigationViewController. By informing the delegate when the navigation is ended, we dismiss by default but also let the developer pop or replace the view controller by implementing
NavigationViewController.mapViewControllerDidCancelNavigation(_:).@JThramer