Rename dismissal delegate method; remove documentation #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also spelled “canceling” and “canceled” the American way, for consistency with the rest of the SDK’s public API.
This documentation is not only redundant to NavigationViewControllerDelegate’s documentation comments, but it also uses inaccurate or outdated names.
1ec5
added
topic: documentation
op-ex
frederoni
approved these changes
Apr 30, 2018
vincethecoder
previously requested changes
Apr 30, 2018
bsudekum
dismissed
vincethecoder’s stale review
@vincethecoder no need to request changes if tests are failing.
1ec5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
NavigationViewControllerDelegate.navigationViewControllerDidEndNavigation(_:cancelled:)tonavigationViewControllerDidDismiss(_:byCanceling:), which reads more like one of the standard UIKit view controller delegate methods. Also prefer the American spelling of cancel* over the British spelling.Removed the delegate method section of the readme. That documentation was not only redundant to NavigationViewControllerDelegate’s documentation comments, but it also used inaccurate or outdated names.
/ref #1318
/cc @frederoni @vincethecoder