Fix various compiler warnings #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
Nov 6, 2018
| @@ -208,7 +208,7 @@ public class CarPlayNavigationViewController: UIViewController { | |||
|
|
|||
| // Update the user puck | |||
| mapView?.updatePreferredFrameRate(for: routeProgress) | |||
| let camera = MGLMapCamera(lookingAtCenter: location.coordinate, fromDistance: 120, pitch: 60, heading: location.course) | |||
| let camera = MGLMapCamera(lookingAtCenter: location.coordinate, acrossDistance: 120, pitch: 60, heading: location.course) | |||
There was a problem hiding this comment.
I think the existing values are meant to be altitudes, not viewing distances. See #1815.
There was a problem hiding this comment.
Dropped this commit
frederoni
force-pushed
the
fred/dep-warn
branch
from
782a1d7 to
24561b6
Compare
1ec5
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary guard of a non-optional subscript.
cc @1ec5