Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix camera initializer deprecation warnings #1815

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Fix camera initializer deprecation warnings #1815

merged 1 commit into from
Nov 7, 2018

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Nov 6, 2018

Fixed camera initializer deprecation warnings introduced by mapbox/mapbox-gl-native#12966.

/cc @frederoni

@1ec5 1ec5 self-assigned this Nov 6, 2018
@1ec5 1ec5 requested a review from frederoni November 6, 2018 19:25
@1ec5 1ec5 added the build Issues related to builds and dependency management. label Nov 6, 2018
@1ec5 1ec5 added this to the v0.24.0 milestone Nov 6, 2018
@frederoni
Copy link
Contributor

I have a similar in #1810 :)

@1ec5 1ec5 mentioned this pull request Nov 6, 2018
Merged
@1ec5
Copy link
Contributor Author

1ec5 commented Nov 6, 2018

Oops, didn’t notice that PR. I think these values were meant to be altitudes, though, not viewing distances.

@frederoni
Copy link
Contributor

👍 I'll rebase 1810 and omit the camera changes.

@1ec5 1ec5 merged commit 6f01af8 into master Nov 7, 2018
@1ec5 1ec5 deleted the 1ec5-camera-altitude-warning branch November 7, 2018 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederoni frederoni frederoni approved these changes

Assignees

@1ec5 1ec5

Labels
build Issues related to builds and dependency management.
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@1ec5 @frederoni