upgrade https-proxy-agent (#747)

mapbox · Nov 27, 2024 · 0b568f5 · 0b568f5
1 parent 1159038
commit 0b568f5
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 11 deletions.
diff --git a/lib/install.js b/lib/install.js
@@ -55,8 +55,8 @@ function place_binary(uri, targetDir, opts, callback) {
                     process.env.npm_config_proxy;
   let agent;
   if (proxyUrl) {
-    const ProxyAgent = require('https-proxy-agent');
-    agent = new ProxyAgent(proxyUrl);
+    const { HttpsProxyAgent } = require('https-proxy-agent');
+    agent = new HttpsProxyAgent(proxyUrl);
     log.log('download', `proxy agent configured using: "${proxyUrl}"`);
   }
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -25,7 +25,7 @@
   "dependencies": {
     "consola": "^3.2.3",
     "detect-libc": "^2.0.0",
-    "https-proxy-agent": "^5.0.0",
+    "https-proxy-agent": "^7.0.5",
     "node-fetch": "^2.6.7",
     "nopt": "^8.0.0",
     "semver": "^7.5.3",

diff --git a/test/proxy-bcrypt.test.js b/test/proxy-bcrypt.test.js
@@ -6,7 +6,7 @@ const { createUnzip } = require('zlib');
 const os = require('os');
 
 const tar = require('tar-fs');
-const Agent = require('https-proxy-agent');
+const { HttpsProxyAgent } = require('https-proxy-agent');
 const fetch = require('node-fetch');
 const { rimraf } = require('rimraf');
 
@@ -44,7 +44,7 @@ test('setup proxy server', (t) => {
   proxy.startServer({ port: proxyPort });
   process.env.https_proxy = process.env.http_proxy = proxyServer;
 
-  options.agent = new Agent(proxyServer);
+  options.agent = new HttpsProxyAgent(proxyServer);
 
   // make sure the download directory deleted then create an empty one
   rimraf(downloadDir).then(() => {