Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade https-proxy-agent #747

Merged
merged 2 commits into from
Nov 27, 2024
Merged

upgrade https-proxy-agent #747

merged 2 commits into from
Nov 27, 2024

Conversation

benmccann
Copy link
Collaborator

closes #706

@benmccann benmccann mentioned this pull request Jul 1, 2024
Closed
@benmccann
Copy link
Collaborator Author

@cclauss if you're able to give this one a look, this is the last of the libraries needing to be upgraded

@benmccann
Copy link
Collaborator Author

@cclauss I just fixed the merge conflict on this one, so it should be ready to go now

lukekarrys
lukekarrys reviewed Jul 19, 2024
View reviewed changes
lib/install.js Outdated Show resolved Hide resolved
@benmccann benmccann force-pushed the proxy-upgrade branch 2 times, most recently from e37223e to 12c2b08 Compare July 19, 2024 20:27
@benmccann benmccann mentioned this pull request Jul 20, 2024
Closed
@benmccann
Copy link
Collaborator Author

@lukekarrys I've rebased this PR against master, so it's passing the CI now

@benmccann
Copy link
Collaborator Author

@cclauss @lukekarrys could we merge this PR? thanks!

@benmccann benmccann requested a review from a team as a code owner November 26, 2024 23:03
@benmccann benmccann mentioned this pull request Nov 26, 2024
Closed
@benmccann
Copy link
Collaborator Author

@cclauss if you could take a look at this one, it's the last one I'd like to get in before our next release as it's the last outdated dependency that we have

@cclauss cclauss merged commit 0b568f5 into mapbox:master Nov 27, 2024
12 checks passed
@cclauss
Copy link
Collaborator

cclauss commented Nov 27, 2024

Thanks. I am glad you are now a maintainer. FInally, things are moving foreword.

@benmccann benmccann deleted the proxy-upgrade branch November 27, 2024 23:56
@benmccann
Copy link
Collaborator Author

that's great! thank you so much!!

I think that's pretty much all the code changes we need to try for another release. It seems only the changelog and release tooling are left. I just updated the changelog PR if you're able to take a look at it

Happy Thanksgiving!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@lukekarrys lukekarrys Awaiting requested review from lukekarrys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmccann @cclauss @lukekarrys