[iOS] add-camera-padding #1348
[iOS] add-camera-padding #1348
Conversation
| if (!MGLEdgeInsetsEqual(camera.padding, MGLEdgeInsetsZero)) { | ||
| options.padding = MLNEdgeInsetsFromNSEdgeInsets(camera.padding); | ||
| } |
There was a problem hiding this comment.
Moving the discussion of the old PR over to this PR:
Not sure if this is correct, as there is edgePadding as argument as well as in padding in MGLMapCamera. The padding in MGLMapCamera overwrites the param here.
There was a problem hiding this comment.
Let me do some more testing before we merge this.
There was a problem hiding this comment.
I did my testing. However, since this is my first PR in maplibre native I would like to have feedback from someone that knows this part of the code well enough :)
There was a problem hiding this comment.
Not sure if this is correct, as there is edgePadding as argument as well as in padding in MGLMapCamera. The padding in MGLMapCamera overwrites the param here.
The library currently conflates two different concepts as “padding”:
MLNMapView.contentInsetis supposed to be persistent, something the developer sets according to UI that takes up space within the map view, such as a translucent sidebar or a camera “notch” on iOS. The developer should only have to think about this inset when sizing the map view or embedding a subview, not when manipulating or animating the camera. The resulting virtual rectangle is often called a “safe area” on Apple platforms.- Various camera-manipulating methods like
-[MLNMapView setCamera:withDuration:animationTimingFunction:edgePadding:completionHandler:]take anedgePaddingparameter for more precisely targeting the camera transition. In particular, the navigation SDK (and navigation applications in general) need to anchor the user location indicator somewhere other than the center of the safe area, typically in the lower third of the map view.
In the original design in mapbox/mapbox-gl-native#3583, the mbgl::CameraOptions::padding was the sum of the (persistent) content insets and the (temporary) edge padding. mbgl::CameraOptions::padding affected the frame of reference for mbgl::CameraOptions::center, but mbgl::Map::transform never persisted the padding because it had no context about how much of that padding was persistent and how much was temporary.
Unfortunately, a change was made to mbgl that conflated these two concepts, creating quite a headache for iOS/macOS developers: mapbox/mapbox-gl-native#15232 mapbox/mapbox-gl-native#15233. I have recommended that mbgl::Transform decouple the concepts of “padding” and “insets” and even replace “padding” with a more explicit way to anchor the center coordinate within screen space: mapbox/mapbox-gl-native#15233 (comment).
None of this was taken into account on Android; this mbgl functionality was exposed more literally without much regard for the practical use cases. Unfortunately, this means cross-platform libraries like the Flutter library will need to reconcile the two approaches.
JulianBissekkou
changed the title
Which to this date (and at the time the PR was merged) is permissively licensed. |
| - (void)centerSelectedAnnotationWithPadding { | ||
| id<MLNAnnotation> annotation = self.mapView.selectedAnnotations.firstObject; | ||
|
|
||
| if (!annotation) | ||
| return; | ||
|
|
||
| CGPoint point = [self.mapView convertCoordinate:annotation.coordinate toPointToView:self.mapView]; | ||
|
|
||
| // Animate, so that point becomes the the center | ||
| CLLocationCoordinate2D center = [self.mapView convertPoint:point toCoordinateFromView:self.mapView]; | ||
| MLNMapCamera *camera = self.mapView.camera.copy; | ||
| camera.centerCoordinate = center; | ||
| camera.padding = UIEdgeInsetsMake(200, 50, 10, 4); | ||
|
|
||
| [self.mapView setCamera:camera animated:YES]; | ||
| } | ||
|
|
||
| - (void)centerSelectedAnnotationWithoutPadding { |
There was a problem hiding this comment.
I know that this adjustment on the example app is not perfect.
It's been a while since I wrote some objective-c so that's why I quickly adjusted an existing entry in the feature list instead of creating a new one.
If someone has a better idea and can maybe help me out then let me know 👍🏽
|
Sorry for the confusion, this is the iOS changelog: https://github.com/maplibre/maplibre-native/blob/main/platform/ios/platform/ios/CHANGELOG.md |
|
These tests fail. 
E.g.
MLNMapProjectionTests also fails:
|
|
Closing this because its not required anymore. |
Why is this change needed?
We are maintaining the Flutter plugin for maplibre and we are currently implementing maplibre/flutter-maplibre-gl#258 which brings the padding feature to the sdk.
On android we are already able to create camera updates with a padding value, but this is missing on iOS.
This PR exposes the
paddingvalue of theMLNMapCameraso that we are able to implement this feature.This introduces the changes from an unmerged PR that we have seen in the old mapbox repository.
(mapbox-gl-native-ios/pull/323/files)