Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMake 3.24.0+ for Android #3065

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Dec 3, 2024

Android compilation will fail if an older CMake version is found.

So set CMake 3.24 which is needed after #2968.

@louwers louwers added build Related to build, configuration or CI/CD android labels Dec 3, 2024
@louwers louwers requested a review from cgalvan December 3, 2024 20:40
Copy link

github-actions bot commented Dec 3, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3065-compared-to-main.txt

@louwers louwers enabled auto-merge (squash) December 3, 2024 21:42
@louwers louwers merged commit 5c8dd71 into maplibre:main Dec 3, 2024
40 of 46 checks passed
Copy link

github-actions bot commented Dec 3, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3065-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +30% +34.5Mi  +432% +25.8Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3065-compared-to-legacy.txt

Copy link

github-actions bot commented Dec 3, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0102         -0.0098             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3065-compared-to-main.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android build Related to build, configuration or CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants