Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility #295

Closed
11 of 25 tasks
orangemug opened this issue May 10, 2018 · 7 comments
Closed
11 of 25 tasks

Accessibility #295

orangemug opened this issue May 10, 2018 · 7 comments

Comments

@orangemug
Copy link
Collaborator

orangemug commented May 10, 2018

Maputnik should be for everybody, currently we're not a very friendly app for the visually impaired and users with reduced movement. This is a master ticket which outlines some of the steps to make a better more friendly application for those users. Most of the things listed will require separate tickets and more research before development.

Note: I'm not an expert in web accessibility, although I've done a bit of work and quite a bit of reading/research in the past. Please get involved if you'd like to help and lets make Maputnik accessible together

App accessibility

App accessibility how easy it is for users to use our app.

For those which reduced vision

  • Contrast of UI
  • Type size
    • Increasing zoom reduces space for the map pane, could we solve this with a better UI?
  • Increasing browser default font size should increase app font size.
    • Currently it's fixed at 14px in html { /* ... */ }
  • Input elements are currently described with a popup, how does a screen reader cope with these?
  • Color preview very small when not using the color picker (see Make color swatch larger so its easier to see #297)
  • Are errors in the map style accessible by a screen reader?
    • Currently errors are appended to the map pane. I'm assuming closer to the input elements is better for all users.
  • Button links (without hrefs) should be proper <button/>s so they are keyboard accessible (See Made buttons keyboard accessible #298)
  • Mark selected elements in layers panel for screen readers.

Reduced movement

Other accessibility issues

Output accessibility

How easy it is for all of our users to make accessible maps for display in print and on screen.

Making maps for people with reduced vision

Documentation

Hearing loss

  • Do videos support captioning?
    • Overall pretty good 'auto captioning' from youtube. Needs to be reviewed properly. Reviewed captions from @lukasmartinelli youtube videos and they are a few errors but they are minor and understandable. We should continue to use YouTube

Visual

  • Good written documentation for screen readers?

Questions?

I understand colour accessibility and reduced movement, but Maputnik is a visual editor does making it accessible to a screen reader make sense?

Good question, there are lots of varying degrees of reduced visibility. Some users be using a screen reader to assist rather than the only mean of interaction. We should be welcoming to people to give Maputnik a try regardless of their Accessibility Requirements.

Feedback

Any feedback is welcome and encouraged. If anybody wants to get involved or has expertise in either making apps accessible or is a user who uses assistive technologies and would like to help, please leave a comment below.

@pathmapper
Copy link
Contributor

Hi @orangemug, great list!

Just wanted to mention that there is currently a new Mapbox GL Accessibility Plugin developed:
https://github.com/mapbox/mapbox-gl-accessibility/

Maybe it's worth to take a look.

@orangemug
Copy link
Collaborator Author

@pathmapper thanks that's really neat.

@pathmapper
Copy link
Contributor

Add color filters for the main map pane to simulate color blindness

I am currently using http://colororacle.org/ to simulate color blindness.

There are a lot of useful information on the website e.g.

Github Repositories:

@orangemug
Copy link
Collaborator Author

@pathmapper I've attempted to 'add color filters for the main map pane to simulate color blindness' in PR #312

Do you have any ideas or good resources to test we're getting the correct results?

@pathmapper
Copy link
Contributor

pathmapper commented Jun 1, 2018

Great idea using SVG filters @orangemug !

We could check which types are available in colororacle and compare if the OSM Liberty style looks the same using it.

@orangemug
Copy link
Collaborator Author

@pathmapper yeah I guess if we, screenshot the editor with a style loaded and

  • each SVG filter applied
  • each colour oracle filter applied

Then compare the screenshots

@orangemug
Copy link
Collaborator Author

My original reason for not opening individual issues was to not spam the issue tracker. Now that I've completed all the easier items in this issue, I've opened individual issues for all the remaining items to track their progress and make it easier for others to get involved.

Closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants