Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color blindness emulation #312

Merged
merged 1 commit into from
Jun 2, 2018

Conversation

orangemug
Copy link
Collaborator

An initial attempt at adding 'color blindness emulation' to the editor. To use it add a query string param color-blindness-emulation with one of the following values. Note the links point to the branch build of the editor for testing.

This is the first stage, if it's correct we'll merge and work out a way to create a UI

Note: Most of the credit goes to https://github.com/hail2u/color-blindness-emulation

@orangemug orangemug changed the title Initial attempt at color blindness emulation Color blindness emulation Jun 1, 2018
@orangemug orangemug mentioned this pull request Jun 1, 2018
25 tasks
@orangemug
Copy link
Collaborator Author

First up, here is a collection of tools to test against and reference implementations

To test I installed Color Oracle however taking a screenshot with Color Oracle enabled seemed to mess with the colors. I've manually tested with Color Oracle comparing with the osm-liberty style. This wasn't really a good enough test because it was only a visual (side by side) check. But it seemed correct.

Secondly I tested with the http://mapeper.github.io/jsColorblindSimulator/ uploading a screenshot of the editor, the results were as follows

  • achromatomaly - very slight color variation
  • achromatopsia - very slight color variation
  • deuteranomaly - very slight color variation
  • deuteranopia - same
  • protanomaly - same
  • protanopia - same
  • tritanomaly - same
  • tritanopia - very slight color variation

There was very slight color variations in some modes which could be to do with the generation of the screenshots, or some kind of compression. Either way the variation was barely noticeable in the modes highlighted above.

I've also checked the matrixes against other implementations and they are the same.

I believe this to be good to merge.

@orangemug orangemug merged commit fd48d82 into maplibre:master Jun 2, 2018
@orangemug orangemug mentioned this pull request Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant