Keyboard accessible layer options #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to make the following options accessible to keyboard users - reorder layers - duplicate layer - delete layer - hide/show layer
…lity-list-reorder Conflicts: src/components/App.jsx
|
Merging this PR, any objections to the UI please raise a new ticket. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional menu into
<LayerEditor/>. This is to make the following options accessible to keyboard usersI've hidden the icons (delete/duplicate/hide) in the layers list view from the keyboard. The reason being is that I'm aiming to switch to an accessible tree view for the layers list. I believe trying to add in keyboard support for sub items of a treeview would be confusing for the user and difficult to develop. These are now also in the 'vertical ellipsis menu' on the layer pane.
I've also added a header describing the pane (
Layer: [id]) which I'm unsure about.Looking for feedback (CC @gregorywolanski, @pathmapper)
Note: The main objective here is accessibility for keyboard users.
You can see a demo at https://456-84182601-gh.circle-artifacts.com/0/artifacts/build/index.html