-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
you cannot run "npm install" inside of preinstall. this creates an install loop in npm 3+ #650
Comments
In my opinion this is an npm bug and not something I'm planning to change in node-mapnik or node-pre-gyp. Pre-installing node-pre-gyp is desirable for avoiding having to bundle it. Avoiding bundling is desirable to avoid the extra weight of the dependency in the package, the possibility it will get out of sync, and the problem of bundled deps being out of date. |
npm is behaving correctly, as documented and as designed.
This is not a real reason. npm exists so that modules can have dependencies, which are installed during npm install. This issue has already been filed several times by other users. It's frustrating that your response to this issue is to bury your head in the sand and act like it doesn't exist and that npm is somehow at fault. |
@tjwebb I've been unable to replicate this problem myself. Are you able to replicate with npm |
The v3.6.0 release has started bundling node-pre-gyp again. If anyone hits this issue again with >= 3.6.0 please create a new issue. |
If you do add a |
@balasuar - thanks: where is the documentation on this recommendation located? |
because of this: df7d542
You cannot run
npm install
anything inside of thepreinstall
, becausenpm install
runspreinstall
.This is pointless, anyway, because
node-pre-gyp
is a dependency already.This happens:
and so on, forever, until eventually it looks like this:
etc.
The text was updated successfully, but these errors were encountered: