Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: predicate_label examples -> predicate_id #369

Closed
joeflack4 opened this issue Jun 29, 2024 · 0 comments · Fixed by #370
Closed

Docs: predicate_label examples -> predicate_id #369

joeflack4 opened this issue Jun 29, 2024 · 0 comments · Fixed by #370
Assignees
@matentzn
Milestone
1.0.0

Comments

@joeflack4
Copy link
Contributor

The examples section in the predicate_label page looks like it should be in the predicate_id page.
matentzn added a commit that referenced this issue Jul 4, 2024
@matentzn
Move predicate_label examples to predicate_id in sssom_schema.yaml
3ff5804 
Fixes #369.

The examples for the predicate_id slot where in the wrong slot (predicate_label), here we move them to be correct.

I have also added a single example for the predicate_label slot.
@matentzn matentzn mentioned this issue Jul 4, 2024
Merged
7 tasks
@matentzn matentzn added this to the 1.0.0 milestone Aug 4, 2024
@matentzn matentzn self-assigned this Aug 4, 2024
matentzn added a commit that referenced this issue Aug 6, 2024
@matentzn @joeflack4
Move predicate_label examples to predicate_id in sssom_schema.yaml (#370
66d32ad 
)

Fixes #369.

The examples for the predicate_id slot where in the wrong slot
(predicate_label), here we move them to be correct.

I have also added a single example for the predicate_label slot.

---------

Co-authored-by: Joe Flack <joeflack4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matentzn matentzn

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Move predicate_label examples to predicate_id in sssom_schema.yaml mapping-commons/sssom
2 participants
@matentzn @joeflack4