Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move predicate_label examples to predicate_id in sssom_schema.yaml #370

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

matentzn
Copy link
Collaborator

@matentzn matentzn commented Jul 4, 2024

Fixes #369.

The examples for the predicate_id slot where in the wrong slot (predicate_label), here we move them to be correct.

I have also added a single example for the predicate_label slot.

  • docs/ have been added/updated if necessary
  • make test has been run locally
  • tests have been added/updated (if applicable)
  • CHANGELOG.md has been updated.

If you are proposing a change to the SSSOM metadata model, you must

  • provide a full, working and valid example in examples/
  • provide a link to the related GitHub issue in the see_also field of the linkml model
  • provide a link to a valid example in the see_also field of the linkml model

Fixes #369.

The examples for the predicate_id slot where in the wrong slot (predicate_label), here we move them to be correct.

I have also added a single example for the predicate_label slot.
@matentzn matentzn requested review from ehartley and joeflack4 July 4, 2024 11:26
src/sssom_schema/schema/sssom_schema.yaml Outdated Show resolved Hide resolved
src/sssom_schema/schema/sssom_schema.yaml Show resolved Hide resolved
Co-authored-by: Joe Flack <joeflack4@gmail.com>
Copy link
Contributor

@ehartley ehartley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@matentzn matentzn requested a review from hrshdhgd August 3, 2024 05:27
@matentzn matentzn added the documentation Improvements or additions to documentation label Aug 4, 2024
@matentzn matentzn self-assigned this Aug 4, 2024
Copy link
Contributor

@hrshdhgd hrshdhgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run make all ... same as #386 (review)

@matentzn matentzn merged commit 66d32ad into master Aug 6, 2024
3 checks passed
@matentzn matentzn deleted the matentzn-patch-1 branch August 6, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: predicate_label examples -> predicate_id
4 participants