Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtm-gdx-poi3d module #600

Closed

Conversation

schedul-xor
Copy link

image

Moved poi3d to vtm-gdx-models and imported from vtm-web-app.

@schedul-xor schedul-xor closed this Nov 7, 2018
@schedul-xor schedul-xor reopened this Nov 7, 2018
@devemux86
Copy link
Collaborator

Thanks, see my comment here.

@schedul-xor schedul-xor mentioned this pull request Nov 7, 2018
@devemux86
Copy link
Collaborator

@Gustl22 any more work on 3D classes or can be moved and where?

"http://google-web-toolkit.googlecode.com/svn/trunk/distro-source/core/src/gwt-module.dtd">
<module rename-to="VtmGdxModels">
<source path="org/oscim/model/poi3d" />
</module>
Copy link
Collaborator

@devemux86 devemux86 Nov 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid mixing GWT stuff with core modules? Can use vtm-web for that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried moving tags to vtm-web/src/org/oscim/gdx/VtmWeb.gwt.xml, but it didn't work.

Compiling module org.oscim.web.VtmWebApp
   Finding entry point classes
      Tracing compile failure path for type 'org.oscim.web.client.GwtLauncher'
         [ERROR] Errors in 'file:/home/xor/local/m/p/w/vtm/vtm-web-app/src/org/oscim/web/client/GwtLauncher.java'
            [ERROR] Line 47: No source code is available for type org.oscim.gdx.client.MapConfig; did you forget to inherit a required module?
            [ERROR] Line 47: No source code is available for type org.oscim.core.Tile; did you forget to inherit a required module?
         [ERROR] Errors in 'com/badlogic/gdx/backends/gwt/GwtApplicationConfiguration.java'
            [ERROR] com.badlogic.gdx.backends.gwt.GwtGraphics.OrientationLockType cannot be resolved to a type
         [ERROR] Errors in 'file:/home/xor/local/m/p/w/vtm/vtm-web/src/org/oscim/gdx/emu/com/badlogic/gdx/backends/gwt/GwtApplication.java'
            [ERROR] com.badlogic.gdx.backends.gwt.GwtGraphics cannot be resolved to a type
         [ERROR] Errors in 'file:/home/xor/local/m/p/w/vtm/vtm-web/src/org/oscim/gdx/emu/com/badlogic/gdx/backends/gwt/GwtGraphics.java'
            [ERROR] Line 117: No source code is available for type org.oscim.gdx.client.GdxGL; did you forget to inherit a required module?

Source paths are relative.

@Gustl22
Copy link

Gustl22 commented Nov 7, 2018

@Gustl22 any more work on 3D classes or can be moved and where?

I wanted to solve #601 before make it available to other platforms. But I didn't solve the bug yet.
Wanted to move it to vtm-gdx/src/org/oscim/gdx/poi3d. I think package name model is slightly too abstract. Maybe you find a better name, but this is not that important for me. model is ok, too.
Second is that vtm-gdx would need the vtm-model dependencies, which makes gdx package heavier (?)

@devemux86
Copy link
Collaborator

devemux86 commented Nov 7, 2018

Wanted to move it to vtm-gdx/src/org/oscim/gdx/poi3d. I think package name model is slightly too abstract. Maybe you find a better name, but this is not that important for me. model is ok, too.

Most suitable package seems the org.oscim.gdx.poi3d ("similar" to existing one).

Second is that vtm-gdx would need the vtm-model dependencies, which makes gdx package heavier (?)

In that case we can create a new vtm-gdx-poi3d module to host the classes, as vtm-models should be optional.

@Gustl22
Copy link

Gustl22 commented Nov 8, 2018

Agreed, if @schedul-xor doesn't mind :)

@schedul-xor
Copy link
Author

No problem!

@Gustl22
Copy link

Gustl22 commented Dec 2, 2018

Now that #601 should be solved with #604, @devemux86 is invited to merge your PR (eventually splitted in one refactoring part and one PR for web implementation only). Afterwards I will add support for Android.

@devemux86
Copy link
Collaborator

Sorry, the force push hadn't created any notification. 🙂

@devemux86 devemux86 added this to the 0.11.0 milestone Dec 3, 2018
@devemux86 devemux86 changed the title General poi3d models vtm-gdx-poi3d module Dec 3, 2018
devemux86 pushed a commit that referenced this pull request Dec 3, 2018
@devemux86
Copy link
Collaborator

Thanks!
Merged via 09a6cf2.

@devemux86 devemux86 closed this Dec 3, 2018
@schedul-xor schedul-xor deleted the general-poi3d-models branch February 22, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants