-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-introducing @emotion/react [Summary Issue] #1395
Labels
status:ready
Ready for development
Comments
First PR (#1436) is for this points in: 'A Component that acts as base for styling with the following features' Next step after merging first PR:
Following steps:
|
This was referenced Oct 29, 2021
This was referenced Nov 11, 2021
This was referenced Nov 29, 2021
@ti10le close? :) |
@sebald noo GlobalStyles and rewrite of some docs guidelines missing |
This was referenced Nov 30, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Last year we switched from
@emotion/react
(back then it was@emotion/core
) to the framework agnostic@emotion/css
. One of the main reasons for this was that we wanted to useclassName
and hooks for styling instead of using thecss
prop.Using the
css
prop came with some issue, like leaking thecss
prop to every single component, which was not our intention. Just to name one.Context
The reason we want to switch back is that we ran into multiple issues implementing global styles and the order in which styles are applied (see
#1197 #1317 and #1372). Especially the later one will could always lead to problems in the future.
Thus, the decision to use
@emtoion/react
again. The hope is that we have better control over style ordering (emotion currently only has a "prepend" option for the cache, there is no way to insert at a specific order, see also emotion-js/emotion#2037) and can remove custom implementations like the@marigold/server
.Consequences
We have to reimplement all the features of the current styling solution. Meaning:
as
prop -> polymorphic component)css
prop) that will generated stylesvariants
prop)theme
and other configurationstheme.root
)The text was updated successfully, but these errors were encountered: