Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: use Element in Box + necessary fix changes #1440

Merged
merged 19 commits into from
Nov 10, 2021
Merged

feature: use Element in Box + necessary fix changes #1440

merged 19 commits into from
Nov 10, 2021

Conversation

ti10le
Copy link
Contributor

@ti10le ti10le commented Oct 29, 2021

ti10le and others added 15 commits October 14, 2021 11:02
@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: bc8f04d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@marigold/components Patch
@marigold/system Patch
docs Patch
@marigold/icons Patch
@marigold/theme-b2b Patch
@marigold/theme-core Patch
@marigold/theme-unicorn Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the type:feature New feature or component label Oct 29, 2021
@coveralls
Copy link

coveralls commented Oct 29, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling bc8f04d on remove-emotion/css into c4ae5c5 on main.

@ti10le ti10le marked this pull request as ready for review October 29, 2021 07:50
@sebald sebald self-requested a review November 9, 2021 08:47
@sebald sebald self-assigned this Nov 9, 2021
sebald
sebald approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@sebald sebald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't mix so much different stuff :P

@sebald sebald merged commit c1da52c into main Nov 10, 2021
@sebald sebald deleted the remove-emotion/css branch November 10, 2021 17:50
@ti10le
Copy link
Contributor Author

ti10le commented Nov 11, 2021

Please don't mix so much different stuff :P

Yes.. but these two other files had errors after the change in the Box

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebald sebald sebald approved these changes

Assignees

@sebald sebald

Labels
type:feature New feature or component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti10le @coveralls @sebald