feat(comp): remove useStyles from Select #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bfbb00c The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sebald
reviewed
Nov 29, 2021
| @@ -94,7 +83,7 @@ export const Select = ({ | |||
| {required ? ( | |||
| <Box as="span" display="inline-flex" alignItems="center"> | |||
| {props.label} | |||
| <Required size={16} className={errorClassName} /> | |||
| <Box as={Required} size={16} css={{ color: 'error' }} /> | |||
There was a problem hiding this comment.
lassen das so, aber eigentlich haben wir ja "currentColor" sprich wenn das label die farbe ändert, ändert sich das Icon auch mit! :)
sebald
reviewed
Nov 29, 2021
| <Box | ||
| as={ArrowUp} | ||
| size={16} | ||
| css={{ fill: disabled ? 'disabled' : 'text' }} |
There was a problem hiding this comment.
We dont need this because if disabled then ArrowUp is never visible. Uuups
sebald
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1395