Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update storybook to version 7 #2807

Merged
merged 27 commits into from
Feb 28, 2023
Merged

chore: update storybook to version 7 #2807

merged 27 commits into from
Feb 28, 2023

Conversation

sarahgm
Copy link
Member

@sarahgm sarahgm commented Feb 21, 2023

closes #2772

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2023

🦋 Changeset detected

Latest commit: 4d046ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@marigold/jest-config Minor
@marigold/storybook-config Major
@marigold/components Minor
@marigold/docs Minor
@marigold/theme-b2b Major
@marigold/theme-core Major
@marigold/theme-unicorn Major
@marigold/system Minor
@marigold/icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added type:feature New feature or component type:infrastructure Tooling and other chores labels Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #2807 (e1217dd) into main (33329ac) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e1217dd differs from pull request most recent head 4d046ac. Consider uploading reports for the commit 4d046ac to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##              main     #2807     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          104       105      +1     
  Lines         1110      6507   +5397     
  Branches       162       171      +9     
===========================================
+ Hits          1110      6507   +5397     
Impacted Files Coverage Δ
packages/components/src/Checkbox/CheckboxGroup.tsx 100.00% <100.00%> (ø)
packages/tokens/src/size.ts 100.00% <0.00%> (ø)
packages/tokens/src/color.ts 100.00% <0.00%> (ø)
packages/tokens/src/layer.ts 100.00% <0.00%> (ø)
packages/tokens/src/space.ts 100.00% <0.00%> (ø)
packages/tokens/src/aspect.ts 100.00% <0.00%> (ø)
packages/tokens/src/border.ts 100.00% <0.00%> (ø)
packages/tokens/src/shadow.ts 100.00% <0.00%> (ø)
packages/components/src/Box.ts 100.00% <0.00%> (ø)
packages/tokens/src/opacity.ts 100.00% <0.00%> (ø)
... and 94 more

sebald
sebald previously approved these changes Feb 23, 2023
config/storybook/main.ts Outdated Show resolved Hide resolved
@@ -3,3 +3,6 @@
href="https://fonts.googleapis.com/css2?family=Inter:wght@400;600;700&display=swap"
rel="stylesheet"
/>
<script>
window.global = window;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for? :-O

Copy link
Member Author

@sarahgm sarahgm Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for Storybook to work correctly, without it throws an error: Uncaught ReferenceError: global is not defined at ../../node_modules/.pnpm/jest-mock@27.5.1/node_modules/jest-mock/build/index.js @sebald

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json Outdated Show resolved Hide resolved
@sarahgm sarahgm requested a review from sebald February 28, 2023 16:16
@sebald sebald merged commit f917582 into main Feb 28, 2023
@sebald sebald deleted the update-storybook branch February 28, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or component type:infrastructure Tooling and other chores
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Storybook 7
2 participants