-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update storybook to version 7 #2807
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
f862a46
update storybook
sarahgm 7ac1d82
Merge branch 'main' into update-storybook
sarahgm 5e118e0
save this
sarahgm 5f816db
Merge branch 'main' into update-storybook
sarahgm 889d11d
storys worked but without args
sarahgm c10f74e
button stories corrections
sarahgm f5707f4
a - b
sarahgm 31956cb
save more stories
sarahgm d8ff750
save
sarahgm a148e3f
save more stories
sarahgm f098de0
refa stories
sarahgm 4da9b97
fix some stories
sarahgm e1249d0
add eslint comment
sarahgm 44fe0e5
Merge branch 'main' into update-storybook
sarahgm 5b31f03
Merge branch 'main' into update-storybook
sarahgm fed48ce
refa inset story
sarahgm 54a14ff
remove coverage token
sarahgm fe48411
tokens
sarahgm 32f4c8b
add dependencies to storybook
sarahgm 88e9ff2
import
sarahgm 4547ba0
Merge branch 'main' into update-storybook
sarahgm d7f33b3
saves
sarahgm 0bfbfcf
update
sarahgm 8b2d1bb
fix the coverage
sarahgm e1217dd
save
sarahgm 81b9530
Merge branch 'main' into update-storybook
sarahgm 4d046ac
Create .changeset/good-turkeys-add.md
sebald File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"@marigold/jest-config": minor | ||
"@marigold/storybook-config": major | ||
"@marigold/components": minor | ||
--- | ||
|
||
chore: update storybook to version 7 + fix coverage |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this for? :-O
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for Storybook to work correctly, without it throws an error:
Uncaught ReferenceError: global is not defined at ../../node_modules/.pnpm/jest-mock@27.5.1/node_modules/jest-mock/build/index.js
@sebaldThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
storybookjs/storybook#15391 (comment)