-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last line of terminal cast goes off-screen #73
Open
Comments
I ended up changing this line in function toViewModel(options) {
...
const frames = cast.frames
.filter(([stamp], i, fs) => stamp >= from && stamp <= to)
.map(([delta, data], i) => [delta, data, liner(data)])
.map(([stamp, data, l], index) => {
const lines = l
.map((chars, y) => {
const words = toWords(chars);
return {
- y: y * fontSize * lineHeight,
+ y: (y-1) * fontSize * lineHeight,
words,
hash: hash(words),
ref: null
};
}); |
MadLittleMods
added a commit
to MadLittleMods/svg-term
that referenced
this issue
Feb 19, 2024
Fix marionebl/svg-term-cli#78 Fix marionebl/svg-term-cli#73 But it's a column and line bigger than it should be
MadLittleMods
added a commit
to MadLittleMods/svg-term
that referenced
this issue
Feb 19, 2024
Fix marionebl/svg-term-cli#73 This problem only manifested when an explicit `--height` was given. Because `options.height` and `cast.height` differ, using the wrong one will result in an off-by-one error. Note: those height values only differ because it errantly seems to be [incremented by one when we load the cast](https://github.com/marionebl/svg-term/blob/f761fcac7dc77520cb6d7c8e28618cd266f74538/src/load-cast.ts#L14). We should probably remove that increment (see next commit).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here is an example:
made with this command:
As you can see the last line with prompt and user input only shows after it comes up.
Repository: mihael-stormrage/backend-project-lvl1
The text was updated successfully, but these errors were encountered: