Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last column is partially cut #78

Open
MasterMedo opened this issue Jul 21, 2021 · 0 comments · May be fixed by marionebl/svg-term#43
Open

Last column is partially cut #78

MasterMedo opened this issue Jul 21, 2021 · 0 comments · May be fixed by marionebl/svg-term#43

Comments

@MasterMedo
Copy link

I had a similar problem as #33, the last column was partially cut and wrapped around to the 0th column.
But in my case, I just ran cat demo.cast | svg-term --out cast.svg.
I solved it by manually editing svg-term's index.js's render function, after loading the cast options I manually incremented the value of width cast.width += 1;.
MadLittleMods added a commit to MadLittleMods/svg-term that referenced this issue Feb 19, 2024
@MadLittleMods
Fix viewport overflowing horizontally and last line cut-off
16edf3f 
Fix marionebl/svg-term-cli#78
Fix marionebl/svg-term-cli#73

But it's a column and line bigger than it should be
MadLittleMods added a commit to MadLittleMods/svg-term that referenced this issue Feb 19, 2024
@MadLittleMods
Hide overflow from other frames
9cad1dc 
Fix marionebl/svg-term-cli#78
MadLittleMods added a commit to MadLittleMods/svg-term that referenced this issue Feb 19, 2024
@MadLittleMods
Fix previous frame leaking into current frame
b7b4911 
Part of marionebl/svg-term-cli#78

All of the frames in a long horizontal strip. Because the frame
text slightly overflows each frame, the content from the last
frame was slightly visible in the current frame.

Essentially, we're adding `overflow: hidden` but in SVG form
so regardless of content in frames, they can't affect each
other.
MadLittleMods added a commit to MadLittleMods/svg-term that referenced this issue Feb 19, 2024
@MadLittleMods
Remove magic values giving bad rounding and grid results
a35cfd1 
Other part of marionebl/svg-term-cli#78

Essentially, we were previously just multiplying `1.67` (`fontSize`)
by `0.6` to try to cancel it back down to `1`. But since these values
don't match perfectly, they gave horribly off-pixel and inaccurate values.
For example at a column width of `80`, this calculation gives `80.16`
pixels and puts each character on an off-grid position. It also means each
line overflows by 1.6px and was the root cause of
marionebl/svg-term-cli#78

Since we just want each character to take up 1 unit of width space,
we don't need to do any calculation, the `x` value should just be
the character index in the line.
@MadLittleMods MadLittleMods linked a pull request Feb 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix viewport overflow issues MadLittleMods/svg-term
1 participant
@MasterMedo