-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last column is partially cut #78
Comments
MadLittleMods
added a commit
to MadLittleMods/svg-term
that referenced
this issue
Feb 19, 2024
Fix marionebl/svg-term-cli#78 Fix marionebl/svg-term-cli#73 But it's a column and line bigger than it should be
MadLittleMods
added a commit
to MadLittleMods/svg-term
that referenced
this issue
Feb 19, 2024
MadLittleMods
added a commit
to MadLittleMods/svg-term
that referenced
this issue
Feb 19, 2024
Part of marionebl/svg-term-cli#78 All of the frames in a long horizontal strip. Because the frame text slightly overflows each frame, the content from the last frame was slightly visible in the current frame. Essentially, we're adding `overflow: hidden` but in SVG form so regardless of content in frames, they can't affect each other.
MadLittleMods
added a commit
to MadLittleMods/svg-term
that referenced
this issue
Feb 19, 2024
Other part of marionebl/svg-term-cli#78 Essentially, we were previously just multiplying `1.67` (`fontSize`) by `0.6` to try to cancel it back down to `1`. But since these values don't match perfectly, they gave horribly off-pixel and inaccurate values. For example at a column width of `80`, this calculation gives `80.16` pixels and puts each character on an off-grid position. It also means each line overflows by 1.6px and was the root cause of marionebl/svg-term-cli#78 Since we just want each character to take up 1 unit of width space, we don't need to do any calculation, the `x` value should just be the character index in the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I had a similar problem as #33, the last column was partially cut and wrapped around to the 0th column.
But in my case, I just ran
cat demo.cast | svg-term --out cast.svg
.I solved it by manually editing
svg-term
'sindex.js
'srender
function, after loading thecast
options I manually incremented the value of widthcast.width += 1;
.The text was updated successfully, but these errors were encountered: