Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.2 broke some emphasis conversions #1378

Closed
pscanf opened this issue Nov 23, 2018 · 1 comment
Closed

0.5.2 broke some emphasis conversions #1378

pscanf opened this issue Nov 23, 2018 · 1 comment
Labels
category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue

Comments

@pscanf
Copy link

pscanf commented Nov 23, 2018

Describe the bug
Emphasized markdown text followed by a : character doesn't get converted to emphasized html. Other characters such as , and ; also break the conversion.

To Reproduce

// Transforms correctly with 0.5.1
require("marked")("The following _should be emphasized_:")
'<p>The following <em>should be emphasized</em>:</p>\n'
// Transforms incorrectly with 0.5.2
require("marked")("The following _should be emphasized_:")
'<p>The following _should be emphasized_:</p>\n'
  1. Marked Demo
  2. CommonMark Demo

Expected behavior
Emphasized markdown text followed by a : character should get converted to emphasized html.

@UziTech UziTech added L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue category: inline elements labels Nov 23, 2018
@UziTech
Copy link
Member

UziTech commented Nov 23, 2018

might be related to #1351 (comment)

PRs are welcome 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
Projects
None yet
Development

No branches or pull requests

2 participants