Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emphasis followed by a punctuation #1383

Merged
merged 3 commits into from
Dec 5, 2018
Merged

Conversation

RomanHotsiy
Copy link
Contributor

@RomanHotsiy RomanHotsiy commented Dec 5, 2018

Marked version:

0.5.2

Markdown flavor: CommonMark

Description

My previous PR #1351 caused a regression for some emphasis use cases. There is no specific CommonMark test to catch that. @styfle could you suggest me where to put the test for this specific use case so it won't break in the future?

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

lib/marked.js Outdated Show resolved Hide resolved
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me if all the tests pass

Co-Authored-By: RomanGotsiy <gotsijroman@gmail.com>
@UziTech
Copy link
Member

UziTech commented Dec 5, 2018

@RomanHotsiy
Copy link
Contributor Author

@UziTech Added a few extra tests and fixed lint issue.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful, thanks!

@styfle styfle changed the title Fix emphasis followed by a punctuation (fixes #1378) Fix emphasis followed by a punctuation Dec 5, 2018
@styfle styfle merged commit f8d556a into markedjs:master Dec 5, 2018
RomanHotsiy pushed a commit to Redocly/redoc that referenced this pull request Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants