-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix emphasis followed by a punctuation #1383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me if all the tests pass
Co-Authored-By: RomanGotsiy <gotsijroman@gmail.com>
@RomanGotsiy you can add a test in https://github.com/markedjs/marked/blob/master/test/specs/marked/marked.json |
@UziTech Added a few extra tests and fixed lint issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wonderful, thanks!
The new release includes markedjs/marked#1383.
Marked version:
0.5.2
Markdown flavor: CommonMark
Description
My previous PR #1351 caused a regression for some emphasis use cases. There is no specific CommonMark test to catch that. @styfle could you suggest me where to put the test for this specific use case so it won't break in the future?
Contributor
Committer
In most cases, this should be a different person than the contributor.