Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] We have to use '\' to add the '(' #1434

Closed
ghost opened this issue Mar 6, 2019 · 3 comments · Fixed by #1435
Closed

[Bug] We have to use '\' to add the '(' #1434

ghost opened this issue Mar 6, 2019 · 3 comments · Fixed by #1435
Labels
category: links has PR The issue has a Pull Request associated L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue

Comments

@ghost
Copy link

ghost commented Mar 6, 2019 •
edited by ghost
Loading

image

Notice that we have to add '' in front of "(", otherwises this won't be analyzed out.

The original words are in the attached sample:
Sample.txt.

For more，please refer to：nodejs/nodejs.org#2119
@styfle styfle added the L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue label Mar 6, 2019
@styfle
Copy link
Member

styfle commented Mar 6, 2019

@Maledong Thanks for reporting this bug!

Here's a smaller repro steps:

[One](https://example.com/1) ([Two](https://example.com/2)) [Three](https://example.com/3)

marked demo

/cc @UziTech looks like a regression in 0.6.1 because it works fine in 0.6.0

@UziTech UziTech mentioned this issue Mar 6, 2019
Merged
4 tasks
@UziTech
Copy link
Member

UziTech commented Mar 6, 2019

this is fixed in #1435

demo

@UziTech UziTech added the has PR The issue has a Pull Request associated label Mar 6, 2019
@ghost
Copy link
Author

ghost commented Mar 6, 2019

Thanks! A very quick fixture, waiting for your publishment :)

@ghost ghost mentioned this issue Apr 8, 2019
Merged
fhemberger pushed a commit to nodejs/nodejs.org that referenced this issue Apr 8, 2019
@fhemberger
Update the packages (#2172)
58f8094 
1) IMPORTANT Fix：Update the 'marked' package, because there's an existing BUG
reported by @rvagg, and this is already fixed in its v0.6.2. For more
Ref：#2119.
Fixture：markedjs/marked#1434.

2) A general upgration of the two packages:
a) require-dir: 1.0.0 => 1.2.0
b) semver: 5.6.0 => 6.0.0 (Fix a technical bug, important)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: links has PR The issue has a Pull Request associated L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Links parens
2 participants
@UziTech @styfle